Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 279203002: Revert of Rollback option put behind the flag. (Closed)

Created:
6 years, 7 months ago by vabr (Chromium)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Revert of Rollback option put behind the flag. (https://codereview.chromium.org/267393011/) Reason for revert: This seems to have broken ResetFirstAfterBootTest.SuccessOnRollbackRequested on http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/23801. Original issue's description: > Rollback option put behind the flag. > > BUG=368860 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269753 TBR=nkostylev@chromium.org,merkulova@chromium.org NOTREECHECKS=true NOTRY=true BUG=368860 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -37 lines) Patch
M chrome/browser/chromeos/login/reset_browsertest.cc View 3 chunks +18 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Created Revert of Rollback option put behind the flag.
6 years, 7 months ago (2014-05-12 10:04:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/279203002/1
6 years, 7 months ago (2014-05-12 10:04:32 UTC) #2
commit-bot: I haz the power
Change committed as 269762
6 years, 7 months ago (2014-05-12 10:05:21 UTC) #3
Nikita (slow)
CQ committed CL and ignored test failure (will file a bug): https://codereview.chromium.org/267393011 This bot failed ...
6 years, 7 months ago (2014-05-12 10:58:46 UTC) #4
vabr (Chromium)
6 years, 7 months ago (2014-05-12 12:44:12 UTC) #5
Message was sent while issue was closed.
On 2014/05/12 10:58:46, Nikita Kostylev wrote:
> CQ committed CL and ignored test failure (will file a bug):
> 
> https://codereview.chromium.org/267393011
> 
> This bot failed but is still seen green on the CL
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...

That's interesting. Thanks, Nikita, for digging into it!

Powered by Google App Engine
This is Rietveld 408576698