Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Side by Side Diff: chrome/browser/chromeos/login/reset_browsertest.cc

Issue 279203002: Revert of Rollback option put behind the flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/chromeos/login/login_display_host_impl.h" 9 #include "chrome/browser/chromeos/login/login_display_host_impl.h"
10 #include "chrome/browser/chromeos/login/login_manager_test.h" 10 #include "chrome/browser/chromeos/login/login_manager_test.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 RegisterSomeUser(); 98 RegisterSomeUser();
99 } 99 }
100 100
101 IN_PROC_BROWSER_TEST_F(ResetTest, ShowAndCancel) { 101 IN_PROC_BROWSER_TEST_F(ResetTest, ShowAndCancel) {
102 JSExpect("!!document.querySelector('#reset.hidden')"); 102 JSExpect("!!document.querySelector('#reset.hidden')");
103 EXPECT_EQ(0, update_engine_client_->can_rollback_call_count()); 103 EXPECT_EQ(0, update_engine_client_->can_rollback_call_count());
104 InvokeResetScreen(); 104 InvokeResetScreen();
105 JSExpect("!document.querySelector('#reset.hidden')"); 105 JSExpect("!document.querySelector('#reset.hidden')");
106 CloseResetScreen(); 106 CloseResetScreen();
107 JSExpect("!!document.querySelector('#reset.hidden')"); 107 JSExpect("!!document.querySelector('#reset.hidden')");
108 if (CommandLine::ForCurrentProcess()->HasSwitch( 108 EXPECT_EQ(1, update_engine_client_->can_rollback_call_count());
109 switches::kEnableRollbackOption))
110 EXPECT_EQ(1, update_engine_client_->can_rollback_call_count());
111 } 109 }
112 110
113 IN_PROC_BROWSER_TEST_F(ResetTest, PRE_RestartBeforePowerwash) { 111 IN_PROC_BROWSER_TEST_F(ResetTest, PRE_RestartBeforePowerwash) {
114 RegisterSomeUser(); 112 RegisterSomeUser();
115 } 113 }
116 114
117 IN_PROC_BROWSER_TEST_F(ResetTest, RestartBeforePowerwash) { 115 IN_PROC_BROWSER_TEST_F(ResetTest, RestartBeforePowerwash) {
118 PrefService* prefs = g_browser_process->local_state(); 116 PrefService* prefs = g_browser_process->local_state();
119 117
120 InvokeResetScreen(); 118 InvokeResetScreen();
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 update_engine_client_->set_can_rollback_check_result(true); 170 update_engine_client_->set_can_rollback_check_result(true);
173 // rollback available and unchecked 171 // rollback available and unchecked
174 InvokeResetScreen(); 172 InvokeResetScreen();
175 ClickResetButton(); 173 ClickResetButton();
176 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls()); 174 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
177 EXPECT_EQ(2, session_manager_client_->start_device_wipe_call_count()); 175 EXPECT_EQ(2, session_manager_client_->start_device_wipe_call_count());
178 EXPECT_EQ(0, update_engine_client_->rollback_call_count()); 176 EXPECT_EQ(0, update_engine_client_->rollback_call_count());
179 CloseResetScreen(); 177 CloseResetScreen();
180 OobeScreenWaiter(OobeDisplay::SCREEN_ACCOUNT_PICKER).Wait(); 178 OobeScreenWaiter(OobeDisplay::SCREEN_ACCOUNT_PICKER).Wait();
181 179
182 if (CommandLine::ForCurrentProcess()->HasSwitch( 180 // rollback available and checked
183 switches::kEnableRollbackOption)) { 181 InvokeResetScreen();
184 // rollback available and checked 182 ASSERT_TRUE(content::ExecuteScript(
185 InvokeResetScreen(); 183 web_contents(),
186 ASSERT_TRUE(content::ExecuteScript( 184 "$('reset-rollback-checkbox').checked = true;"));
187 web_contents(), 185 ClickResetButton();
188 "$('reset-rollback-checkbox').checked = true;")); 186 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
189 ClickResetButton(); 187 EXPECT_EQ(2, session_manager_client_->start_device_wipe_call_count());
190 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls()); 188 EXPECT_EQ(1, update_engine_client_->rollback_call_count());
191 EXPECT_EQ(2, session_manager_client_->start_device_wipe_call_count());
192 EXPECT_EQ(1, update_engine_client_->rollback_call_count());
193 }
194 } 189 }
195 190
196 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, PRE_PowerwashRequested) { 191 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, PRE_PowerwashRequested) {
197 PrefService* prefs = g_browser_process->local_state(); 192 PrefService* prefs = g_browser_process->local_state();
198 prefs->SetBoolean(prefs::kRollbackRequested, false); 193 prefs->SetBoolean(prefs::kRollbackRequested, false);
199 prefs->SetBoolean(prefs::kFactoryResetRequested, true); 194 prefs->SetBoolean(prefs::kFactoryResetRequested, true);
200 RegisterSomeUser(); 195 RegisterSomeUser();
201 } 196 }
202 197
203 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, PowerwashRequested) { 198 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, PowerwashRequested) {
(...skipping 14 matching lines...) Expand all
218 RegisterSomeUser(); 213 RegisterSomeUser();
219 } 214 }
220 215
221 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, ErrorOnRollbackRequested) { 216 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, ErrorOnRollbackRequested) {
222 OobeScreenWaiter(OobeDisplay::SCREEN_OOBE_RESET).Wait(); 217 OobeScreenWaiter(OobeDisplay::SCREEN_OOBE_RESET).Wait();
223 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls()); 218 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
224 EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count()); 219 EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count());
225 EXPECT_EQ(0, update_engine_client_->rollback_call_count()); 220 EXPECT_EQ(0, update_engine_client_->rollback_call_count());
226 JSExpect("!$('reset').classList.contains('revert-promise')"); 221 JSExpect("!$('reset').classList.contains('revert-promise')");
227 ClickResetButton(); 222 ClickResetButton();
228 if (CommandLine::ForCurrentProcess()->HasSwitch( 223 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
229 switches::kEnableRollbackOption)) { 224 EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count());
230 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls()); 225 EXPECT_EQ(1, update_engine_client_->rollback_call_count());
231 EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count()); 226 JSExpect("$('reset').classList.contains('revert-promise')");
232 EXPECT_EQ(1, update_engine_client_->rollback_call_count()); 227 UpdateEngineClient::Status error_update_status;
233 JSExpect("$('reset').classList.contains('revert-promise')"); 228 error_update_status.status = UpdateEngineClient::UPDATE_STATUS_ERROR;
234 UpdateEngineClient::Status error_update_status; 229 update_engine_client_->NotifyObserversThatStatusChanged(error_update_status);
235 error_update_status.status = UpdateEngineClient::UPDATE_STATUS_ERROR; 230 OobeScreenWaiter(OobeDisplay::SCREEN_ERROR_MESSAGE).Wait();
236 update_engine_client_->NotifyObserversThatStatusChanged(
237 error_update_status);
238 OobeScreenWaiter(OobeDisplay::SCREEN_ERROR_MESSAGE).Wait();
239 }
240 } 231 }
241 232
242 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, 233 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest,
243 PRE_SuccessOnRollbackRequested) { 234 PRE_SuccessOnRollbackRequested) {
244 PrefService* prefs = g_browser_process->local_state(); 235 PrefService* prefs = g_browser_process->local_state();
245 prefs->SetBoolean(prefs::kRollbackRequested, true); 236 prefs->SetBoolean(prefs::kRollbackRequested, true);
246 prefs->SetBoolean(prefs::kFactoryResetRequested, true); 237 prefs->SetBoolean(prefs::kFactoryResetRequested, true);
247 RegisterSomeUser(); 238 RegisterSomeUser();
248 } 239 }
249 240
250 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, SuccessOnRollbackRequested) { 241 IN_PROC_BROWSER_TEST_F(ResetFirstAfterBootTest, SuccessOnRollbackRequested) {
251 OobeScreenWaiter(OobeDisplay::SCREEN_OOBE_RESET).Wait(); 242 OobeScreenWaiter(OobeDisplay::SCREEN_OOBE_RESET).Wait();
252 ClickResetButton(); 243 ClickResetButton();
253 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls()); 244 EXPECT_EQ(0, power_manager_client_->num_request_restart_calls());
254 EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count()); 245 EXPECT_EQ(0, session_manager_client_->start_device_wipe_call_count());
255 EXPECT_EQ(1, update_engine_client_->rollback_call_count()); 246 EXPECT_EQ(1, update_engine_client_->rollback_call_count());
256 UpdateEngineClient::Status ready_for_reboot_status; 247 UpdateEngineClient::Status ready_for_reboot_status;
257 ready_for_reboot_status.status = 248 ready_for_reboot_status.status =
258 UpdateEngineClient::UPDATE_STATUS_UPDATED_NEED_REBOOT; 249 UpdateEngineClient::UPDATE_STATUS_UPDATED_NEED_REBOOT;
259 update_engine_client_->NotifyObserversThatStatusChanged( 250 update_engine_client_->NotifyObserversThatStatusChanged(
260 ready_for_reboot_status); 251 ready_for_reboot_status);
261 EXPECT_EQ(1, power_manager_client_->num_request_restart_calls()); 252 EXPECT_EQ(1, power_manager_client_->num_request_restart_calls());
262 } 253 }
263 254
264 255
265 } // namespace chromeos 256 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698