pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2791993002: Fix dart2js warnings and add test to ensure it stays clean. (Closed)

Patch Set: Address comments and fix duplicated library names. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart ('k') | pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index 63448b83172b3def29be45248238e0facd05aa85..98529ac530cf5eae5b67e9963c409f0c87ba19e2 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -397,7 +397,9 @@ class ProgramBuilder {

if (returnType.isFunctionType) {

functionType = returnType;

} else if (returnType.treatAsDynamic ||

- _compiler.types.isSubtype(returnType,

+ _compiler.types.isSubtype(

+ returnType,

+ // ignore: UNNECESSARY_CAST

backend.commonElements.functionType as DartType)) {

if (returnType.isTypedef) {

ResolutionTypedefType typedef = returnType;