chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java - Issue 2791973003: [Payments] Normalize contact info phone# in PaymentResponse on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java

Issue 2791973003: [Payments] Normalize contact info phone# in PaymentResponse on Android. (Closed)

Patch Set: Updated ContactDetails tests expectations to reflect the new phone formatting Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java

index 7dab341f514c493ee2fa8dd27784a1572adfc498..b2fe942b231e8ff1456885abefb134ca7f5d065a 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java

@@ -63,7 +63,7 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {

public void testPay() throws InterruptedException, ExecutionException, TimeoutException {

triggerUIAndWait(mReadyToPay);

clickAndWait(R.id.button_primary, mDismissed);

- expectResultContains(new String[] {"Jon Doe", "555-555-5555", "jon.doe@google.com"});

+ expectResultContains(new String[] {"Jon Doe", "+15555555555", "jon.doe@google.com"});

}

/** Attempt to add invalid contact information and cancel the transaction. */

@@ -94,7 +94,7 @@ public class PaymentRequestContactDetailsTest extends PaymentRequestTestBase {

clickInEditorAndWait(R.id.payments_edit_done_button, mReadyToPay);

clickAndWait(R.id.button_primary, mDismissed);

- expectResultContains(new String[] {"Jane Jones", "999-999-9999", "jane.jones@google.com"});

+ expectResultContains(new String[] {"Jane Jones", "+19999999999", "jane.jones@google.com"});

}

/** Quickly pressing on "add contact info" and then [X] should not crash. */