chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java - Issue 2791973003: [Payments] Normalize contact info phone# in PaymentResponse on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java

Issue 2791973003: [Payments] Normalize contact info phone# in PaymentResponse on Android. (Closed)

Patch Set: Updated ContactDetails tests expectations to reflect the new phone formatting Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java

index 413cb26bbe2edb3befa476ef995a5796b0ad3f4e..a60a9ba12917e60768a25c4e434b47719e05fa97 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentResponseHelper.java

@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.payments;

import org.chromium.chrome.browser.autofill.PersonalDataManager;

import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;

import org.chromium.chrome.browser.autofill.PersonalDataManager.NormalizedAddressRequestDelegate;

+import org.chromium.chrome.browser.autofill.PhoneNumberUtil;

import org.chromium.chrome.browser.payments.ui.PaymentOption;

import org.chromium.payments.mojom.PaymentResponse;

@@ -55,6 +56,12 @@ public class PaymentResponseHelper implements NormalizedAddressRequestDelegate {

mPaymentResponse.payerName = ((AutofillContact) selectedContact).getPayerName();

mPaymentResponse.payerPhone = ((AutofillContact) selectedContact).getPayerPhone();

mPaymentResponse.payerEmail = ((AutofillContact) selectedContact).getPayerEmail();

+ // Normalize the phone number only if it's not null since this calls native code.

+ if (mPaymentResponse.payerPhone != null) {

+ mPaymentResponse.payerPhone =

+ PhoneNumberUtil.formatForResponse(mPaymentResponse.payerPhone);

+ }

}

// Set up the shipping section of the response.