Upstream StorageManager estimate() test to WPT

Upstream StorageManager estimate() test to WPT

BUG=692147
Review-Url: https://codereview.chromium.org/2791963004
Cr-Commit-Position: refs/heads/master@{#462147}
Committed: https://chromium.googlesource.com/chromium/src/+/fbe66db9feab5393ad9f5064988bdd2404644da8

[jsbell, 2017-04-03 21:23:37]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 21:24:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 22:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 22:44:50]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-04-04 20:42:48]

jsbell@chromium.org changed reviewers:
+ pwnall@chromium.org

[jsbell, 2017-04-04 20:42:49]

pwnall@ - can you review?

[pwnall, 2017-04-04 21:08:35]

LGTM w/ nits

https://codereview.chromium.org/2791963004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-estimate.https.html
(right):

https://codereview.chromium.org/2791963004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-estimate.https.html:30:
const open = indexedDB.open(dbname);
I think you can remove some boilerplate by using createDatabase in
https://github.com/w3c/web-platform-tests/blob/master/IndexedDB/support-promi...
but being completely explicit is also fine.

https://codereview.chromium.org/2791963004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-estimate.https.html:66:
}, 'estimate() shows usage increase after large IndexedDB record is stored');
large -> 1MB?

[jsbell, 2017-04-05 15:57:27]

https://codereview.chromium.org/2791963004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-estimate.https.html
(right):

https://codereview.chromium.org/2791963004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-estimate.https.html:30:
const open = indexedDB.open(dbname);
On 2017/04/04 21:08:34, pwnall wrote:
> I think you can remove some boilerplate by using createDatabase in
>
https://github.com/w3c/web-platform-tests/blob/master/IndexedDB/support-promi...
> but being completely explicit is also fine.

Don't want a test in storage/ to depend on IndexedDB/

[jsbell, 2017-04-05 16:58:12]

thanks!

https://codereview.chromium.org/2791963004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-estimate.https.html
(right):

https://codereview.chromium.org/2791963004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/storage/storagemanager-estimate.https.html:66:
}, 'estimate() shows usage increase after large IndexedDB record is stored');
On 2017/04/04 21:08:34, pwnall wrote:
> large -> 1MB?

Done.

[jsbell, 2017-04-05 16:58:17]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2017-04-05 16:58:18]

The patchset sent to the CQ was uploaded after l-g-t-m from pwnall@chromium.org
Link to the patchset: https://codereview.chromium.org/2791963004/#ps20001
(title: "Update comment per review feedback")

[commit-bot: I haz the power, 2017-04-05 16:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:11:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491411497739130,
"parent_rev": "fa74fc69658bd030e2f4ae96da88244d42cd32e8", "commit_rev":
"fbe66db9feab5393ad9f5064988bdd2404644da8"}

[commit-bot: I haz the power, 2017-04-05 18:12:39]

Description was changed from

==========
Upstream StorageManager estimate() test to WPT

BUG=692147
==========

to

==========
Upstream StorageManager estimate() test to WPT

BUG=692147

Review-Url: https://codereview.chromium.org/2791963004
Cr-Commit-Position: refs/heads/master@{#462147}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbe66db9feab5393ad9f5064988b...
==========

[commit-bot: I haz the power, 2017-04-05 18:12:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fbe66db9feab5393ad9f5064988b...