Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Issue 2791963002: Merge to M58: Resolve preloadResponse of Navigation Preload even if the response body is empty. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
index 8f4f9a01776170ab3cd3d5a5a4dedf2b40072320..daff428240e0d65f92a89359812ebd42b6949755 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
@@ -113,10 +113,13 @@ void FetchEvent::onNavigationPreloadResponse(
return;
DCHECK(m_preloadResponseProperty);
ScriptState::Scope scope(scriptState);
- FetchResponseData* responseData = FetchResponseData::createWithBuffer(
- new BodyStreamBuffer(scriptState, new BytesConsumerForDataConsumerHandle(
- scriptState->getExecutionContext(),
- std::move(dataConsumeHandle))));
+ FetchResponseData* responseData =
+ dataConsumeHandle
+ ? FetchResponseData::createWithBuffer(new BodyStreamBuffer(
+ scriptState, new BytesConsumerForDataConsumerHandle(
+ scriptState->getExecutionContext(),
+ std::move(dataConsumeHandle))))
+ : FetchResponseData::create();
Vector<KURL> urlList(1);
urlList[0] = response->url();
responseData->setURLList(urlList);

Powered by Google App Engine
This is Rietveld 408576698