Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp

Issue 2791963002: Merge to M58: Resolve preloadResponse of Navigation Preload even if the response body is empty. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/serviceworkers/FetchEvent.h" 5 #include "modules/serviceworkers/FetchEvent.h"
6 6
7 #include "bindings/core/v8/ScriptState.h" 7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/ToV8.h" 8 #include "bindings/core/v8/ToV8.h"
9 #include "bindings/core/v8/V8HiddenValue.h" 9 #include "bindings/core/v8/V8HiddenValue.h"
10 #include "modules/fetch/BytesConsumerForDataConsumerHandle.h" 10 #include "modules/fetch/BytesConsumerForDataConsumerHandle.h"
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 } 106 }
107 107
108 void FetchEvent::onNavigationPreloadResponse( 108 void FetchEvent::onNavigationPreloadResponse(
109 ScriptState* scriptState, 109 ScriptState* scriptState,
110 std::unique_ptr<WebURLResponse> response, 110 std::unique_ptr<WebURLResponse> response,
111 std::unique_ptr<WebDataConsumerHandle> dataConsumeHandle) { 111 std::unique_ptr<WebDataConsumerHandle> dataConsumeHandle) {
112 if (!scriptState->contextIsValid()) 112 if (!scriptState->contextIsValid())
113 return; 113 return;
114 DCHECK(m_preloadResponseProperty); 114 DCHECK(m_preloadResponseProperty);
115 ScriptState::Scope scope(scriptState); 115 ScriptState::Scope scope(scriptState);
116 FetchResponseData* responseData = FetchResponseData::createWithBuffer( 116 FetchResponseData* responseData =
117 new BodyStreamBuffer(scriptState, new BytesConsumerForDataConsumerHandle( 117 dataConsumeHandle
118 scriptState->getExecutionContext(), 118 ? FetchResponseData::createWithBuffer(new BodyStreamBuffer(
119 std::move(dataConsumeHandle)))); 119 scriptState, new BytesConsumerForDataConsumerHandle(
120 scriptState->getExecutionContext(),
121 std::move(dataConsumeHandle))))
122 : FetchResponseData::create();
120 Vector<KURL> urlList(1); 123 Vector<KURL> urlList(1);
121 urlList[0] = response->url(); 124 urlList[0] = response->url();
122 responseData->setURLList(urlList); 125 responseData->setURLList(urlList);
123 responseData->setStatus(response->httpStatusCode()); 126 responseData->setStatus(response->httpStatusCode());
124 responseData->setStatusMessage(response->httpStatusText()); 127 responseData->setStatusMessage(response->httpStatusText());
125 responseData->setResponseTime(response->toResourceResponse().responseTime()); 128 responseData->setResponseTime(response->toResourceResponse().responseTime());
126 const HTTPHeaderMap& headers( 129 const HTTPHeaderMap& headers(
127 response->toResourceResponse().httpHeaderFields()); 130 response->toResourceResponse().httpHeaderFields());
128 for (const auto& header : headers) { 131 for (const auto& header : headers) {
129 responseData->headerList()->append(header.key, header.value); 132 responseData->headerList()->append(header.key, header.value);
(...skipping 15 matching lines...) Expand all
145 } 148 }
146 149
147 DEFINE_TRACE(FetchEvent) { 150 DEFINE_TRACE(FetchEvent) {
148 visitor->trace(m_observer); 151 visitor->trace(m_observer);
149 visitor->trace(m_request); 152 visitor->trace(m_request);
150 visitor->trace(m_preloadResponseProperty); 153 visitor->trace(m_preloadResponseProperty);
151 ExtendableEvent::trace(visitor); 154 ExtendableEvent::trace(visitor);
152 } 155 }
153 156
154 } // namespace blink 157 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698