Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete

Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete


BUG=704956, 475060
Review-Url: https://codereview.chromium.org/2791923003
Cr-Commit-Position: refs/heads/master@{#461433}
Committed: https://chromium.googlesource.com/chromium/src/+/14af3e715ff775b85391f96baf0847e3b53ccf38

[xunjieli, 2017-04-03 13:11:55]

Description was changed from

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete


BUG=704956
==========

to

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete


BUG=704956
==========

[xunjieli, 2017-04-03 13:11:55]

xunjieli@chromium.org changed reviewers:
+ bnc@chromium.org

[xunjieli, 2017-04-03 13:14:52]

Bence, I am fairly sure that this code is unreachable. Tarun(tbansal@) added a
DCHECK in
https://chromium.googlesource.com/chromium/src/+/0844a896c0334b3541315e79d104...
to make sure this is dead code.

I have run into this several times while trying to figure out what's going on in
these classes. I think we should just remove it.

[xunjieli, 2017-04-03 13:14:57]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 13:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-04-03 13:15:28]

Description was changed from

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete


BUG=704956
==========

to

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete


BUG=704956,475060
==========

[Bence, 2017-04-03 13:53:08]

On 2017/04/03 13:14:52, xunjieli wrote:
> Bence, I am fairly sure that this code is unreachable. Tarun(tbansal@) added a
> DCHECK in
>
https://chromium.googlesource.com/chromium/src/+/0844a896c0334b3541315e79d104...
> to make sure this is dead code.
> 
> I have run into this several times while trying to figure out what's going on
in
> these classes. I think we should just remove it.

LGTM.  The more we are scratching the surface of HttpStreamFactoryImpl::Job, the
more I get the feeling that this class needs a lot of cleanup work.

[xunjieli, 2017-04-03 13:59:42]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-04-03 14:00:34]

On 2017/04/03 13:53:08, Bence wrote:
> On 2017/04/03 13:14:52, xunjieli wrote:
> > Bence, I am fairly sure that this code is unreachable. Tarun(tbansal@) added
a
> > DCHECK in
> >
>
https://chromium.googlesource.com/chromium/src/+/0844a896c0334b3541315e79d104...
> > to make sure this is dead code.
> > 
> > I have run into this several times while trying to figure out what's going
on
> in
> > these classes. I think we should just remove it.
> 
> LGTM.  The more we are scratching the surface of HttpStreamFactoryImpl::Job,
the
> more I get the feeling that this class needs a lot of cleanup work.

Couldn't agree more. These few classes are giving me nightmares :)

[xunjieli, 2017-04-03 14:00:39]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-04-03 14:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 15:26:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491228039284360, "parent_rev":
"9975ad63f85f1fe76100602db98800b9232aa454", "commit_rev":
"14af3e715ff775b85391f96baf0847e3b53ccf38"}

[commit-bot: I haz the power, 2017-04-03 15:27:09]

Description was changed from

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete


BUG=704956,475060
==========

to

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete


BUG=704956,475060

Review-Url: https://codereview.chromium.org/2791923003
Cr-Commit-Position: refs/heads/master@{#461433}
Committed:
https://chromium.googlesource.com/chromium/src/+/14af3e715ff775b85391f96baf08...
==========

[commit-bot: I haz the power, 2017-04-03 15:27:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14af3e715ff775b85391f96baf08...