Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2791923003: Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete (Closed)

Created:
3 years, 8 months ago by xunjieli
Modified:
3 years, 8 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, tbansal1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unreachable code in HttpStreamFactoryImpl::Job::OnPreconnectsComplete BUG=704956, 475060 Review-Url: https://codereview.chromium.org/2791923003 Cr-Commit-Position: refs/heads/master@{#461433} Committed: https://chromium.googlesource.com/chromium/src/+/14af3e715ff775b85391f96baf0847e3b53ccf38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xunjieli
Bence, I am fairly sure that this code is unreachable. Tarun(tbansal@) added a DCHECK in ...
3 years, 8 months ago (2017-04-03 13:14:52 UTC) #3
Bence
On 2017/04/03 13:14:52, xunjieli wrote: > Bence, I am fairly sure that this code is ...
3 years, 8 months ago (2017-04-03 13:53:08 UTC) #7
xunjieli
On 2017/04/03 13:53:08, Bence wrote: > On 2017/04/03 13:14:52, xunjieli wrote: > > Bence, I ...
3 years, 8 months ago (2017-04-03 14:00:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791923003/1
3 years, 8 months ago (2017-04-03 14:00:57 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 15:27:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14af3e715ff775b85391f96baf08...

Powered by Google App Engine
This is Rietveld 408576698