Issue 2791903002: Extend notifications.mojom for expandable notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2791903002: Extend notifications.mojom for expandable notifications. (Closed)

Created:
3 years, 8 months ago by yhanada

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Extend notifications.mojom for expandable notifications. - Add |TOGGLE_EXPANSION| value to ArcNotificationEvent enum. - Add |expand_state| value to ArcNotificationData. BUG=703989 Review-Url: https://codereview.chromium.org/2765923003 Cr-Commit-Position: refs/heads/master@{#460062} (cherry picked from commit c787104b181d6ca1356c1f0b82257ed5a62ad633) Review-Url: https://codereview.chromium.org/2791903002 . Cr-Commit-Position: refs/branch-heads/3029@{#537} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/0d0f9e3fb82e37ac0bab42324165a2fb4dd636aa

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -1 line)			Patch
M	components/arc/common/notifications.mojom	View	4 chunks	+13 lines, -1 line	0 comments	Download
M	ui/arc/notification/arc_custom_notification_item.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/arc/notification/arc_custom_notification_item.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

yhanada

3 years, 8 months ago (2017-04-03 01:53:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0d0f9e3fb82e37ac0bab42324165a2fb4dd636aa.