Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2791873002: How to fix WebContentsImplBrowserTest.NoResetOnBeforeUnloadCanceledOnCommit. (Closed)

Created:
3 years, 8 months ago by Avi (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Peter Beverloo, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

How to fix WebContentsImplBrowserTest.NoResetOnBeforeUnloadCanceledOnCommit. BUG=655628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -108 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 6 chunks +85 lines, -69 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/shell/browser/shell_javascript_dialog_manager.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M content/test/content_browser_test_utils_internal.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/content_browser_test_utils_internal.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698