Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2791853002: Add a warning for strict secure cookie policy (Closed)

Created:
3 years, 8 months ago by sgurun-gerrit only
Modified:
3 years, 8 months ago
Reviewers:
Nate Fischer
CC:
android-webview-reviews_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a warning for strict secure cookie policy Add a warning to ease catching bugs that originate due to strict secure policy. This policy has created bugs in WebViews apps that use WebView setCookie API to set secure cookies for HTTP domains. BUG=707480 Review-Url: https://codereview.chromium.org/2791853002 Cr-Commit-Position: refs/heads/master@{#461324} Committed: https://chromium.googlesource.com/chromium/src/+/bff9177a06145165275e20245a3b7ecf9c4156e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M android_webview/native/cookie_manager.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sgurun-gerrit only
On 2017/04/01 03:51:18, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:ntfschr@chromium.org ptal,
3 years, 8 months ago (2017-04-01 03:51:26 UTC) #3
Nate Fischer
lgtm
3 years, 8 months ago (2017-04-01 03:56:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791853002/1
3 years, 8 months ago (2017-04-01 13:23:10 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 13:56:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bff9177a06145165275e20245a3b...

Powered by Google App Engine
This is Rietveld 408576698