third_party/WebKit/Source/core/html/HTMLVideoElement.h - Issue 2791813003: Fix broken draw/upload paths from videos to 2D canvas and WebGL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.h

Issue 2791813003: Fix broken draw/upload paths from videos to 2D canvas and WebGL. (Closed)

Patch Set: Fix per review feedback from sandersd@. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.h b/third_party/WebKit/Source/core/html/HTMLVideoElement.h

index 385cc3a62fc01554d991c0381d50fc32f3ae21d9..8e3b11a76309684a3d4043f8389ed2510b50c2ea 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.h

@@ -75,9 +75,10 @@ class CORE_EXPORT HTMLVideoElement final : public HTMLMediaElement,

void paintCurrentFrame(PaintCanvas*, const IntRect&, const PaintFlags*) const;

// Used by WebGL to do GPU-GPU textures copy if possible.

- // The caller is responsible for allocating the destination texture.

bool copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interface*,

GLuint texture,

+ GLenum internalFormat,

+ GLenum type,

bool premultiplyAlpha,

bool flipY);