media/blink/webmediaplayer_impl.h - Issue 2791813003: Fix broken draw/upload paths from videos to 2D canvas and WebGL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2791813003: Fix broken draw/upload paths from videos to 2D canvas and WebGL. (Closed)

Patch Set: Fix per review feedback from sandersd@. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl.h

diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h

index 4726d393661f966f93097be588c2708bbb9f301c..837b92d3cb83bb8f0a84aaf2285e408efb767d7d 100644

--- a/media/blink/webmediaplayer_impl.h

+++ b/media/blink/webmediaplayer_impl.h

@@ -173,6 +173,8 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl

bool copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interface* gl,

unsigned int texture,

+ unsigned internal_format,

+ unsigned type,

bool premultiply_alpha,

bool flip_y) override;