Serialize and deserialize HostCache for persistence

Serialize and deserialize HostCache for persistence
    
HostCache was already being serialized for NetLog, but that code will
soon be needed for persistence as well, so move it into HostCache and
add the reverse operation.

BUG=605149
Review-Url: https://codereview.chromium.org/2791653002
Cr-Commit-Position: refs/heads/master@{#476083}
Committed: https://chromium.googlesource.com/chromium/src/+/af3ec7bf5692ea667b3dccc3b6140fb8aae41ea7

[mgersh, 2017-05-26 16:53:59]

Description was changed from

==========
WIP
==========

to

==========
Serialize and deserialize HostCache for persistence
    
HostCache was already being serialized for NetLog, but that code will
soon be needed for persistence as well, so move it into HostCache and
add the reverse operation.

BUG=605149
==========

[mgersh, 2017-05-26 16:54:13]

Patchset #1 (id:1) has been deleted

[mgersh, 2017-05-26 16:54:19]

Patchset #1 (id:20001) has been deleted

[mgersh, 2017-05-26 16:54:26]

Patchset #1 (id:40001) has been deleted

[mgersh, 2017-05-26 16:57:27]

mgersh@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[mgersh, 2017-05-26 16:57:27]

PTAL

[Julia Tuttle, 2017-05-30 16:15:17]

lgtm with a couple nits.

https://codereview.chromium.org/2791653002/diff/60001/net/dns/host_cache.cc
File net/dns/host_cache.cc (right):

https://codereview.chromium.org/2791653002/diff/60001/net/dns/host_cache.cc#n...
net/dns/host_cache.cc:34: // String constants for dictionary keys.
Suffix these with "key" (e.g. kHostnameKey)?

https://codereview.chromium.org/2791653002/diff/60001/net/dns/host_cache.cc#n...
net/dns/host_cache.cc:45: for (base::ListValue::const_iterator it =
value->begin(); it != value->end();
Clear |list| before adding to it?

https://codereview.chromium.org/2791653002/diff/60001/net/log/net_log_util.cc
File net/log/net_log_util.cc (right):

https://codereview.chromium.org/2791653002/diff/60001/net/log/net_log_util.cc...
net/log/net_log_util.cc:387: cache_info_dict->Set("entries",
Ooh, that's slick!

[mgersh, 2017-05-31 16:25:55]

Thanks!

https://codereview.chromium.org/2791653002/diff/60001/net/dns/host_cache.cc
File net/dns/host_cache.cc (right):

https://codereview.chromium.org/2791653002/diff/60001/net/dns/host_cache.cc#n...
net/dns/host_cache.cc:34: // String constants for dictionary keys.
On 2017/05/30 16:15:17, Julia Tuttle wrote:
> Suffix these with "key" (e.g. kHostnameKey)?

Done.

https://codereview.chromium.org/2791653002/diff/60001/net/dns/host_cache.cc#n...
net/dns/host_cache.cc:45: for (base::ListValue::const_iterator it =
value->begin(); it != value->end();
On 2017/05/30 16:15:17, Julia Tuttle wrote:
> Clear |list| before adding to it?

Done.

[mgersh, 2017-05-31 16:26:41]

The CQ bit was checked by mgersh@chromium.org

[mgersh, 2017-05-31 16:26:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/2791653002/#ps80001
(title: "comments")

[commit-bot: I haz the power, 2017-05-31 16:27:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 17:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:17:32]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[mgersh, 2017-05-31 18:11:37]

The CQ bit was checked by mgersh@chromium.org

[mgersh, 2017-05-31 18:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/2791653002/#ps90001
(title: "fix warning")

[commit-bot: I haz the power, 2017-05-31 18:12:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 21:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:33:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mgersh, 2017-05-31 21:35:33]

The CQ bit was checked by mgersh@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:36:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 23:15:41]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1496266533393070,
"parent_rev": "35aa2825fa9b58a5f89b53e4a730bd2327cb108b", "commit_rev":
"af3ec7bf5692ea667b3dccc3b6140fb8aae41ea7"}

[commit-bot: I haz the power, 2017-05-31 23:15:50]

Description was changed from

==========
Serialize and deserialize HostCache for persistence
    
HostCache was already being serialized for NetLog, but that code will
soon be needed for persistence as well, so move it into HostCache and
add the reverse operation.

BUG=605149
==========

to

==========
Serialize and deserialize HostCache for persistence
    
HostCache was already being serialized for NetLog, but that code will
soon be needed for persistence as well, so move it into HostCache and
add the reverse operation.

BUG=605149

Review-Url: https://codereview.chromium.org/2791653002
Cr-Commit-Position: refs/heads/master@{#476083}
Committed:
https://chromium.googlesource.com/chromium/src/+/af3ec7bf5692ea667b3dccc3b614...
==========

[commit-bot: I haz the power, 2017-05-31 23:15:52]

Committed patchset #3 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/af3ec7bf5692ea667b3dccc3b614...