Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: ui/compositor/compositor_observer.h

Issue 2791613002: Make CompositorObserver’s destructor protected-and-virtual. (Closed)
Patch Set: Move destructor to the front of class. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/compositor_observer.h
diff --git a/ui/compositor/compositor_observer.h b/ui/compositor/compositor_observer.h
index d5f3371f5a734a3b1bf4eaf2b087fe46a46c5035..5e78b55497e8c7a833b8edd47f4cf208763a2d4e 100644
--- a/ui/compositor/compositor_observer.h
+++ b/ui/compositor/compositor_observer.h
@@ -15,6 +15,8 @@ class Compositor;
// A compositor observer is notified when compositing completes.
class COMPOSITOR_EXPORT CompositorObserver {
public:
+ virtual ~CompositorObserver() {}
danakj 2017/03/31 18:09:42 Thanks, you can use "= default;" instead of "{}" n
themblsha 2017/04/04 17:52:08 Done.
+
// A commit proxies information from the main thread to the compositor
// thread. It typically happens when some state changes that will require a
// composite. In the multi-threaded case, many commits may happen between
« no previous file with comments | « content/browser/renderer_host/browser_compositor_view_mac.mm ('k') | ui/compositor/test/draw_waiter_for_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698