🏠 Defocus omnibox on bottom sheet content touch

[Home] Defocus omnibox on bottom sheet content touch

This changes adds some logic to SuggestionsBottomSheetContent that
defocuses the omnibox when a user interacts with it.

BUG=706898
Review-Url: https://codereview.chromium.org/2791603004
Cr-Commit-Position: refs/heads/master@{#462086}
Committed: https://chromium.googlesource.com/chromium/src/+/2a59d4ca1f08e7b72b829622e86ab12fe9569b2f

[mdjones, 2017-03-31 21:31:48]

Description was changed from

==========
[Home] Defocus omnibox on bottom sheet content touch

This changes adds some logic to SuggestionsBottomSheetContent that
defocuses the omnibox when a user interacts with it.

BUG=706898
==========

to

==========
[Home] Defocus omnibox on bottom sheet content touch

This changes adds some logic to SuggestionsBottomSheetContent that
defocuses the omnibox when a user interacts with it.

BUG=706898
==========

[mdjones, 2017-03-31 21:32:26]

mdjones@chromium.org changed reviewers:
+ dgn@chromium.org, twellington@chromium.org

[mdjones, 2017-03-31 21:32:26]

ptal

[Theresa, 2017-03-31 22:13:15]

lgtm

https://codereview.chromium.org/2791603004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
(right):

https://codereview.chromium.org/2791603004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java:106:
@SuppressLint("ClickableViewAccessibility")
This is probably a real error. Let's add a TODO to revisit this when we do
accessibility for Chrome Home, and maybe start a bug tracking accessibility in
CH so that it doesn't get lost.

[mdjones, 2017-04-01 00:05:48]

https://codereview.chromium.org/2791603004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
(right):

https://codereview.chromium.org/2791603004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java:106:
@SuppressLint("ClickableViewAccessibility")
On 2017/03/31 22:13:15, Theresa wrote:
> This is probably a real error. Let's add a TODO to revisit this when we do
> accessibility for Chrome Home, and maybe start a bug tracking accessibility in
> CH so that it doesn't get lost.

I was thinking that originally, but we are only passively observing the touch
event. I think the lint warning is if this was actively triggering some
functionality (i.e. a button might use this).

[dgn, 2017-04-03 09:58:22]

lgtm

[mdjones, 2017-04-03 16:18:21]

mdjones@chromium.org changed reviewers:
+ bauerb@chromium.org

[mdjones, 2017-04-03 16:18:21]

+bauerb for owners

[Bernhard Bauer, 2017-04-05 09:40:13]

lgtm

[mdjones, 2017-04-05 15:02:47]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 15:49:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491404567330650, "parent_rev":
"22c953300a6f9d3480758598e38cbbf9a6d20101", "commit_rev":
"2a59d4ca1f08e7b72b829622e86ab12fe9569b2f"}

[commit-bot: I haz the power, 2017-04-05 15:50:06]

Description was changed from

==========
[Home] Defocus omnibox on bottom sheet content touch

This changes adds some logic to SuggestionsBottomSheetContent that
defocuses the omnibox when a user interacts with it.

BUG=706898
==========

to

==========
[Home] Defocus omnibox on bottom sheet content touch

This changes adds some logic to SuggestionsBottomSheetContent that
defocuses the omnibox when a user interacts with it.

BUG=706898

Review-Url: https://codereview.chromium.org/2791603004
Cr-Commit-Position: refs/heads/master@{#462086}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a59d4ca1f08e7b72b829622e86a...
==========

[commit-bot: I haz the power, 2017-04-05 15:50:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a59d4ca1f08e7b72b829622e86a...