Create feature and enable data collection for Data Saver site breakdown

Create feature and enable data collection for Data Saver site breakdown

Add a feature to enable the new settings page with site breakdown. Also,
add support so that when Data Saver is enabled on Android, compression
stats collects site information. Don't collect site info when Data Saver
is disabled, and when data usage reporting is disabled (when the proxy 
is turned off) keep the stats. The stats can be manually deleted using 
a button on the settings page.

BUG=615560
Review-Url: https://codereview.chromium.org/2791563002
Cr-Commit-Position: refs/heads/master@{#462691}
Committed: https://chromium.googlesource.com/chromium/src/+/5e5d1c1764d4ebbad4f51ab37f1d9341e6d26efb

[megjablon, 2017-03-31 01:52:55]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 01:53:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 02:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 02:23:04]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[megjablon, 2017-03-31 02:43:36]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 02:43:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-03-31 02:44:01]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 02:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 03:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 03:05:29]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[megjablon, 2017-03-31 06:43:31]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 06:43:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-03-31 06:49:57]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-31 08:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 08:03:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[megjablon, 2017-03-31 20:53:39]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 20:54:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 21:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 21:54:32]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[megjablon, 2017-04-01 01:03:49]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 01:04:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-04-01 01:15:14]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-04-01 01:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 01:48:18]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[megjablon, 2017-04-03 18:09:40]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 18:10:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:19:27]

Dry run: This issue passed the CQ dry run.

[megjablon, 2017-04-03 20:19:18]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 20:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-04-03 20:39:13]

Patchset #1 (id:20001) has been deleted

[megjablon, 2017-04-03 20:44:52]

Description was changed from

==========
Enable data collection and field trial for the new Data Saver settings page

BUG=615560
==========

to

==========
Enable data collection and feature for the new Data Saver site breakdown

Add a feature to enable the new settings page with site breakdown. Also,
add support so that when Data Saver is enabled on Android, compression
stats collects site information. Don't collect site info when Data Saver
is disabled, and when data usage reporting is disabled (when the proxy 
is turned off) keep the stats. The stats can be manually deleted using 
a button on the settings page.

BUG=615560
==========

[megjablon, 2017-04-03 21:02:56]

Patchset #4 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-04-03 21:04:35]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[megjablon, 2017-04-03 21:08:35]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 21:09:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-04-03 21:14:25]

Description was changed from

==========
Enable data collection and feature for the new Data Saver site breakdown

Add a feature to enable the new settings page with site breakdown. Also,
add support so that when Data Saver is enabled on Android, compression
stats collects site information. Don't collect site info when Data Saver
is disabled, and when data usage reporting is disabled (when the proxy 
is turned off) keep the stats. The stats can be manually deleted using 
a button on the settings page.

BUG=615560
==========

to

==========
Create feature and enable data collection for Data Saver site breakdown

Add a feature to enable the new settings page with site breakdown. Also,
add support so that when Data Saver is enabled on Android, compression
stats collects site information. Don't collect site info when Data Saver
is disabled, and when data usage reporting is disabled (when the proxy 
is turned off) keep the stats. The stats can be manually deleted using 
a button on the settings page.

BUG=615560
==========

[megjablon, 2017-04-03 22:00:18]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 22:01:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-04-03 22:03:04]

Patchset #4 (id:140001) has been deleted

[commit-bot: I haz the power, 2017-04-03 23:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 23:05:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[megjablon, 2017-04-03 23:53:41]

megjablon@chromium.org changed reviewers:
+ ryansturm@chromium.org

[megjablon, 2017-04-03 23:53:41]

PTAL, thanks!

[megjablon, 2017-04-05 22:48:41]

megjablon@chromium.org changed reviewers:
+ sclittle@chromium.org
- ryansturm@chromium.org

[megjablon, 2017-04-05 22:48:41]

+sclittle do you have time to take a look?

[sclittle, 2017-04-06 01:07:05]

LGTM % nits

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
File components/data_reduction_proxy/core/browser/data_usage_store.cc (right):

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_usage_store.cc:25: namespace {
nit: could you put this anonymous namespace block inside the
data_reduction_proxy namespace so that you don't need to reference them with the
"data_reduction_proxy::" prefix below?

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
File components/data_reduction_proxy/core/browser/data_usage_store.h (right):

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_usage_store.h:25: const int
kDataUsageBucketLengthInMinutes = 15;
nit: could you make this and the below constant constexpr?

[megjablon, 2017-04-06 22:07:51]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[megjablon, 2017-04-06 22:08:23]

megjablon@chromium.org changed reviewers:
+ holte@chromium.org

[megjablon, 2017-04-06 22:08:24]

holte: histograms.xml

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
File components/data_reduction_proxy/core/browser/data_usage_store.cc (right):

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_usage_store.cc:25: namespace {
On 2017/04/06 01:07:05, sclittle wrote:
> nit: could you put this anonymous namespace block inside the
> data_reduction_proxy namespace so that you don't need to reference them with
the
> "data_reduction_proxy::" prefix below?

Done.

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
File components/data_reduction_proxy/core/browser/data_usage_store.h (right):

https://codereview.chromium.org/2791563002/diff/160001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_usage_store.h:25: const int
kDataUsageBucketLengthInMinutes = 15;
On 2017/04/06 01:07:05, sclittle wrote:
> nit: could you make this and the below constant constexpr?

Done.

[commit-bot: I haz the power, 2017-04-06 22:09:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Steven Holte, 2017-04-06 22:43:23]

lgtm

[commit-bot: I haz the power, 2017-04-06 23:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 23:22:38]

Dry run: This issue passed the CQ dry run.

[megjablon, 2017-04-06 23:24:13]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2017-04-06 23:24:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2791563002/#ps180001
(title: "sclittle comments")

[commit-bot: I haz the power, 2017-04-06 23:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:55:16]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1491521053092840,
"parent_rev": "ce1d00b6d9fc5330576ae210ecbc6a8c2d68a020", "commit_rev":
"5e5d1c1764d4ebbad4f51ab37f1d9341e6d26efb"}

[commit-bot: I haz the power, 2017-04-06 23:56:08]

Description was changed from

==========
Create feature and enable data collection for Data Saver site breakdown

Add a feature to enable the new settings page with site breakdown. Also,
add support so that when Data Saver is enabled on Android, compression
stats collects site information. Don't collect site info when Data Saver
is disabled, and when data usage reporting is disabled (when the proxy 
is turned off) keep the stats. The stats can be manually deleted using 
a button on the settings page.

BUG=615560
==========

to

==========
Create feature and enable data collection for Data Saver site breakdown

Add a feature to enable the new settings page with site breakdown. Also,
add support so that when Data Saver is enabled on Android, compression
stats collects site information. Don't collect site info when Data Saver
is disabled, and when data usage reporting is disabled (when the proxy 
is turned off) keep the stats. The stats can be manually deleted using 
a button on the settings page.

BUG=615560

Review-Url: https://codereview.chromium.org/2791563002
Cr-Commit-Position: refs/heads/master@{#462691}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e5d1c1764d4ebbad4f51ab37f1d...
==========

[commit-bot: I haz the power, 2017-04-06 23:56:11]

Committed patchset #5 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/5e5d1c1764d4ebbad4f51ab37f1d...