Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2791473002: Reuse selectorListMatches for all loops over the selectors in SelectorQuery. (Closed)

Created:
3 years, 8 months ago by esprehn
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, dglazkov, rune
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reuse selectorListMatches for all loops over the selectors in SelectorQuery. This means we need to repeat the SelectorQueryTrait::appendElement + SelectorQueryTrait::shouldOnlyMatchFirstElement dance in two places, but it removes two for loops as a trade and lets us untemplatize the selectorListMatches function which is nice. BUG=703900 Review-Url: https://codereview.chromium.org/2791473002 Cr-Commit-Position: refs/heads/master@{#460949} Committed: https://chromium.googlesource.com/chromium/src/+/3d7c1de5f24317f05204476c657ff93d088aa514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M third_party/WebKit/Source/core/dom/SelectorQuery.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 5 chunks +14 lines, -23 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
esprehn
3 years, 8 months ago (2017-03-30 20:57:48 UTC) #9
dglazkov
lgtm
3 years, 8 months ago (2017-03-30 20:59:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791473002/1
3 years, 8 months ago (2017-03-30 23:06:12 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 00:24:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d7c1de5f24317f05204476c657f...

Powered by Google App Engine
This is Rietveld 408576698