//tools/binary_size: source_path information, change file format, fixes

//tools/binary_size: source_path information, change file format, fixes

Main Changes:
* Parse .ninja files to find source_path information.
* Optimized file format for size. Hopefully should be stable(ish) now.

Other Changes:
* Remove .size.gz. Enforce just .size to reduce complexity.
* Improved how we deal with anonymous namespaces
* Improved GroupBy() functions so they group by entire namespace / path.
* Handling for data symbols that have function parameters in their name.
* Fixed typo in create_html_breakdown.py that made it entirely broken.

BUG=681694
Review-Url: https://codereview.chromium.org/2791433004
Cr-Commit-Position: refs/heads/master@{#461491}
Committed: https://chromium.googlesource.com/chromium/src/+/36752bcf4156e76c6ad0424dfa1d4cc7d38121dd

[agrieve, 2017-03-30 19:47:40]

Description was changed from

==========
//tools/binary_size: source_path information, change file format, fixes

Main Changes:
* Parse .ninja files to find source_path information.
* Optimized file format for size. Hopefully should be stable(ish) now.

Other Changes:
* Remove .size.gz. Enforce just .size to reduce complexity.
* Improved how we deal with anonymous namespaces
* Improved GroupBy() functions so they group by entire namespace / path.
* Handling for data symbols that have function parameters in their name.
* Fixed typo in create_html_breakdown.py that made it entirely broken.

BUG=681694
==========

to

==========
//tools/binary_size: source_path information, change file format, fixes

Main Changes:
* Parse .ninja files to find source_path information.
* Optimized file format for size. Hopefully should be stable(ish) now.

Other Changes:
* Remove .size.gz. Enforce just .size to reduce complexity.
* Improved how we deal with anonymous namespaces
* Improved GroupBy() functions so they group by entire namespace / path.
* Handling for data symbols that have function parameters in their name.
* Fixed typo in create_html_breakdown.py that made it entirely broken.

BUG=681694
==========

[agrieve, 2017-03-30 19:47:40]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-03-30 19:48:09]

Sorry for another big one. I'll try and split them into smaller chunks going
forward.

[estevenson, 2017-04-03 18:14:30]

lgtm

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/file_...
File tools/binary_size/file_format.py (right):

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/file_...
tools/binary_size/file_format.py:164: if os.environ.get('MEASURE_GZIP') == '1':
Was this for local development?

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/map2s...
File tools/binary_size/map2size.py (right):

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/map2s...
tools/binary_size/map2size.py:200: """Calls Analyze with values from args."""
Missed this before, wrong comment.

[agrieve, 2017-04-03 18:29:44]

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/file_...
File tools/binary_size/file_format.py (right):

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/file_...
tools/binary_size/file_format.py:164: if os.environ.get('MEASURE_GZIP') == '1':
On 2017/04/03 18:14:30, estevenson wrote:
> Was this for local development?

It was, but I'd like to keep it in, as it makes it easy to see how large each
section of the file is.

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/map2s...
File tools/binary_size/map2size.py (right):

https://codereview.chromium.org/2791433004/diff/40001/tools/binary_size/map2s...
tools/binary_size/map2size.py:200: """Calls Analyze with values from args."""
On 2017/04/03 18:14:30, estevenson wrote:
> Missed this before, wrong comment.

Done.

[agrieve, 2017-04-03 18:29:50]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-04-03 18:29:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2791433004/#ps60001
(title: "fix comment for _DetectToolPrefix")

[commit-bot: I haz the power, 2017-04-03 18:30:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 18:49:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491244190794330,
"parent_rev": "66c46290f9774951731d1d38ad75d7aa2d1ac23d", "commit_rev":
"36752bcf4156e76c6ad0424dfa1d4cc7d38121dd"}

[commit-bot: I haz the power, 2017-04-03 18:50:10]

Description was changed from

==========
//tools/binary_size: source_path information, change file format, fixes

Main Changes:
* Parse .ninja files to find source_path information.
* Optimized file format for size. Hopefully should be stable(ish) now.

Other Changes:
* Remove .size.gz. Enforce just .size to reduce complexity.
* Improved how we deal with anonymous namespaces
* Improved GroupBy() functions so they group by entire namespace / path.
* Handling for data symbols that have function parameters in their name.
* Fixed typo in create_html_breakdown.py that made it entirely broken.

BUG=681694
==========

to

==========
//tools/binary_size: source_path information, change file format, fixes

Main Changes:
* Parse .ninja files to find source_path information.
* Optimized file format for size. Hopefully should be stable(ish) now.

Other Changes:
* Remove .size.gz. Enforce just .size to reduce complexity.
* Improved how we deal with anonymous namespaces
* Improved GroupBy() functions so they group by entire namespace / path.
* Handling for data symbols that have function parameters in their name.
* Fixed typo in create_html_breakdown.py that made it entirely broken.

BUG=681694

Review-Url: https://codereview.chromium.org/2791433004
Cr-Commit-Position: refs/heads/master@{#461491}
Committed:
https://chromium.googlesource.com/chromium/src/+/36752bcf4156e76c6ad0424dfa1d...
==========

[commit-bot: I haz the power, 2017-04-03 18:50:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/36752bcf4156e76c6ad0424dfa1d...