Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2791433002: Use "protected" instead of "premium" for media content. (Closed)

Created:
3 years, 8 months ago by palmer
Modified:
3 years, 7 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, ericde, hbengali, pangu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use "protected" instead of "premium" for media content. So that the UI strings are consistent across Chrome. BUG=706871 Review-Url: https://codereview.chromium.org/2791433002 Cr-Commit-Position: refs/heads/master@{#469246} Committed: https://chromium.googlesource.com/chromium/src/+/a0996c57176ab23a9f4aac30bc9fadc94de696b9

Patch Set 1 #

Patch Set 2 : Change the other string, too (media -> content). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
palmer
See the bug: There is an inconsistency in the UI strings.
3 years, 8 months ago (2017-03-30 17:25:56 UTC) #2
ddorwin
I know there was some effort put into these strings, so I'd like to make ...
3 years, 8 months ago (2017-03-30 17:49:01 UTC) #4
xhwang
As discussed, this CL lgtm! Please also wait for srahim's approval.
3 years, 7 months ago (2017-04-27 21:27:10 UTC) #6
srahim
On 2017/04/27 21:27:10, xhwang_slow wrote: > As discussed, this CL lgtm! > > Please also ...
3 years, 7 months ago (2017-04-28 22:46:17 UTC) #7
xhwang
On 2017/04/28 22:46:17, srahim wrote: > On 2017/04/27 21:27:10, xhwang_slow wrote: > > As discussed, ...
3 years, 7 months ago (2017-04-28 22:47:43 UTC) #8
palmer
On 2017/04/28 at 22:47:43, xhwang wrote: > On 2017/04/28 22:46:17, srahim wrote: > > On ...
3 years, 7 months ago (2017-05-01 22:33:48 UTC) #9
palmer
srahim: Everything LGTY?
3 years, 7 months ago (2017-05-01 22:36:00 UTC) #10
xhwang
still lgtm
3 years, 7 months ago (2017-05-02 00:00:01 UTC) #11
xhwang
+ericde: For the record, I also checked the "learn more" page for ChromeOS, and the ...
3 years, 7 months ago (2017-05-02 00:08:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791433002/20001
3 years, 7 months ago (2017-05-04 01:22:05 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:10:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a0996c57176ab23a9f4aac30bc9f...

Powered by Google App Engine
This is Rietveld 408576698