[dart:io] Don't close stdin with a socket finalizer

[dart:io] Don't close stdin with a socket finalizer

If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.

Accessing the stdin getter after the stream is explicitly
canceled will result in a FileSystemException.

See also: https://github.com/dart-lang/test/issues/583

fixes #29229

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/8c9c54d833865201abdaadbfa25c0c17b07d9926

[zra, 2017-04-03 21:17:50]

Description was changed from

==========
[dart:io] Don't close stdin with a socket finalizer

fixes #29229
==========

to

==========
[dart:io] Don't close stdin with a socket finalizer

If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.

See also: https://github.com/dart-lang/test/issues/583

fixes #29229
==========

[zra, 2017-04-03 21:18:03]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2017-04-04 04:38:33]

Description was changed from

==========
[dart:io] Don't close stdin with a socket finalizer

If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.

See also: https://github.com/dart-lang/test/issues/583

fixes #29229
==========

to

==========
[dart:io] Don't close stdin with a socket finalizer

If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.

Accessing the stdin getter after the stream is explicitly
canceled will result in a FileSystemException.

See also: https://github.com/dart-lang/test/issues/583

fixes #29229
==========

[zra, 2017-04-04 04:38:34]

zra@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-04-04 20:34:46]

lgtm

https://codereview.chromium.org/2791423002/diff/40001/tests/standalone/io/std...
File tests/standalone/io/stdio_socket_finalizer_test.dart (right):

https://codereview.chromium.org/2791423002/diff/40001/tests/standalone/io/std...
tests/standalone/io/stdio_socket_finalizer_test.dart:22: ReceivePort errorPort =
new ReceivePort();
Dead

[zra, 2017-04-04 20:50:39]

https://codereview.chromium.org/2791423002/diff/40001/tests/standalone/io/std...
File tests/standalone/io/stdio_socket_finalizer_test.dart (right):

https://codereview.chromium.org/2791423002/diff/40001/tests/standalone/io/std...
tests/standalone/io/stdio_socket_finalizer_test.dart:22: ReceivePort errorPort =
new ReceivePort();
On 2017/04/04 20:34:46, rmacnak wrote:
> Dead

Done.

[zra, 2017-04-04 20:57:47]

Description was changed from

==========
[dart:io] Don't close stdin with a socket finalizer

If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.

Accessing the stdin getter after the stream is explicitly
canceled will result in a FileSystemException.

See also: https://github.com/dart-lang/test/issues/583

fixes #29229
==========

to

==========
[dart:io] Don't close stdin with a socket finalizer

If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.

Accessing the stdin getter after the stream is explicitly
canceled will result in a FileSystemException.

See also: https://github.com/dart-lang/test/issues/583

fixes #29229

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8c9c54d833865201abdaadbfa25c0c17b07d9926
==========

[zra, 2017-04-04 20:57:48]

Committed patchset #4 (id:60001) manually as
8c9c54d833865201abdaadbfa25c0c17b07d9926 (presubmit successful).