Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: runtime/bin/process.cc

Issue 2791423002: [dart:io] Don't close stdin with a socket finalizer (Closed)
Patch Set: Address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file_macos.cc ('k') | runtime/bin/socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.cc
diff --git a/runtime/bin/process.cc b/runtime/bin/process.cc
index f6366579652090d6e9c38b2ac020011f390bc089..80133289d3141ced18f0c5a6b77d6c58a02d28d7 100644
--- a/runtime/bin/process.cc
+++ b/runtime/bin/process.cc
@@ -161,12 +161,16 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
&process_stdin, &process_stderr, &pid, &exit_event, &os_error_message);
if (error_code == 0) {
if (mode != kDetached) {
- Socket::SetSocketIdNativeField(stdin_handle, process_stdin, false);
- Socket::SetSocketIdNativeField(stdout_handle, process_stdout, false);
- Socket::SetSocketIdNativeField(stderr_handle, process_stderr, false);
+ Socket::SetSocketIdNativeField(stdin_handle, process_stdin,
+ Socket::kFinalizerNormal);
+ Socket::SetSocketIdNativeField(stdout_handle, process_stdout,
+ Socket::kFinalizerNormal);
+ Socket::SetSocketIdNativeField(stderr_handle, process_stderr,
+ Socket::kFinalizerNormal);
}
if (mode == kNormal) {
- Socket::SetSocketIdNativeField(exit_handle, exit_event, false);
+ Socket::SetSocketIdNativeField(exit_handle, exit_event,
+ Socket::kFinalizerNormal);
}
Process::SetProcessIdNativeField(process, pid);
} else {
« no previous file with comments | « runtime/bin/file_macos.cc ('k') | runtime/bin/socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698