Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

Issue 2791263005: Split MirrorsData methods and MirrorsDataImpl data by element kind. (Closed)
Patch Set: Updated cf. comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
index 1352e4b503cc99d1ac60d05780df351694ff2e54..89a60a213d06769f054c058ea9583d507b7d1ab5 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
@@ -22,13 +22,8 @@ part of dart2js.js_emitter.program_builder;
* case, [needsSetter] is always false. [needsCheckedSetter] is only true when
* type assertions are enabled (checked mode).
*/
-typedef void AcceptField(
- VariableElement member,
- js.Name name,
- js.Name accessorName,
- bool needsGetter,
- bool needsSetter,
- bool needsCheckedSetter);
+typedef void AcceptField(FieldEntity member, js.Name name, js.Name accessorName,
+ bool needsGetter, bool needsSetter, bool needsCheckedSetter);
class FieldVisitor {
final Compiler compiler;
@@ -134,7 +129,7 @@ class FieldVisitor {
}
}
- bool fieldNeedsGetter(VariableElement field) {
+ bool fieldNeedsGetter(FieldElement field) {
assert(field.isField);
if (fieldAccessNeverThrows(field)) return false;
if (backend.mirrorsData.shouldRetainGetter(field)) return true;
@@ -142,7 +137,7 @@ class FieldVisitor {
compiler.codegenWorldBuilder.hasInvokedGetter(field, closedWorld);
}
- bool fieldNeedsSetter(VariableElement field) {
+ bool fieldNeedsSetter(FieldElement field) {
assert(field.isField);
if (fieldAccessNeverThrows(field)) return false;
if (field.isFinal || field.isConst) return false;

Powered by Google App Engine
This is Rietveld 408576698