Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2791223004: cros: UpdateStatusAreaVisibility in WizardControllor::ShowCurrentScreen() (Closed)

Created:
3 years, 8 months ago by Qiang(Joe) Xu
Modified:
3 years, 8 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: UpdateStatusAreaVisibility in WizardControllor::ShowCurrentScreen() Changes: (1) Intentionally remove SetStatusAreaVisible method as it doesn't save much code. (2) For each screen-related status area visibility call, using UpdateStatusAreaVisibilityForScreen method. (3) Add UpdateStatusAreaVisibilityForScreen in ShowCurrentScreen() to fix the bug. BUG=708011 TEST=test that reporter's bug is fixed Review-Url: https://codereview.chromium.org/2791223004 Cr-Commit-Position: refs/heads/master@{#463044} Committed: https://chromium.googlesource.com/chromium/src/+/509a5b53985357e3dce645ad8d92b6769f438a9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -30 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 15 chunks +45 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Qiang(Joe) Xu
Hi Alex, PTAL, thanks
3 years, 8 months ago (2017-04-04 17:25:03 UTC) #3
Alexander Alekseev
lgtm
3 years, 8 months ago (2017-04-07 22:25:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791223004/1
3 years, 8 months ago (2017-04-07 22:38:58 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:23:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/509a5b53985357e3dce645ad8d92...

Powered by Google App Engine
This is Rietveld 408576698