third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp - Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties (Closed)

Patch Set: replace node check with dcheck Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp ('K') | « third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp ('k') | third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

index d8a642235a722592845763e0820ffc60515df369..d8561f9c4b1e00eed2128d2edaaf64e5940dcdca 100644

--- a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

@@ -85,6 +85,8 @@ CSSStyleValueVector InlineStylePropertyMap::GetAllInternal(

return StyleValueFactory::CssValueToStyleValueVector(property_id, *css_value);

}

+// TODO(rjwright): This used to throw in the parent class but now is being used.

+// Make sure it is tested and correct.

meade_UTC10 2017/05/09 04:59:36 Nit: please delete this TODO before submitting :)

CSSStyleValueVector InlineStylePropertyMap::GetAllInternal(

AtomicString custom_property_name) {

const CSSValue* css_value =