third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp - Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp

Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties (Closed)

Patch Set: replace node check with dcheck Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp ('K') | « third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp ('k') | third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp » ('j') | third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp

index e0382645a93876dc30b6c2baa053492ac7c6cea4..eea0289c12f2cd9b28f18828aee50fa22919ac05 100644

--- a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp

@@ -72,8 +72,9 @@ bool FilteredComputedStylePropertyMap::has(const String& property_name,

return !GetAllInternal(property_id).IsEmpty();

if (property_id == CSSPropertyVariable &&

- custom_properties_.Contains(AtomicString(property_name)))

+ custom_properties_.Contains(AtomicString(property_name))) {

return !GetAllInternal(AtomicString(property_name)).IsEmpty();

+ }

meade_UTC10 2017/05/09 04:59:36 nit: unrelated change?

exception_state.ThrowTypeError("Invalid propertyName: " + property_name);

return false;