Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp

Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties (Closed)
Patch Set: replace node check with dcheck Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
index e0382645a93876dc30b6c2baa053492ac7c6cea4..eea0289c12f2cd9b28f18828aee50fa22919ac05 100644
--- a/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
@@ -72,8 +72,9 @@ bool FilteredComputedStylePropertyMap::has(const String& property_name,
return !GetAllInternal(property_id).IsEmpty();
if (property_id == CSSPropertyVariable &&
- custom_properties_.Contains(AtomicString(property_name)))
+ custom_properties_.Contains(AtomicString(property_name))) {
return !GetAllInternal(AtomicString(property_name)).IsEmpty();
+ }
meade_UTC10 2017/05/09 04:59:36 nit: unrelated change?
exception_state.ThrowTypeError("Invalid propertyName: " + property_name);
return false;

Powered by Google App Engine
This is Rietveld 408576698