Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2791193003:
Update type_traits in base/values_unittest.cc (Closed)
DescriptionUpdate type_traits in base/values_unittest.cc
Following last week's sysroot update more type_traits became available on all platforms. This change updates the specific checks in base/values_unittest.cc
BUG=554293
Review-Url: https://codereview.chromium.org/2791193003
Cr-Commit-Position: refs/heads/master@{#461664}
Committed: https://chromium.googlesource.com/chromium/src/+/9d47e9ad141cc0c8d05066751cf748f0fcbc55da
Patch Set 1 #Patch Set 2 : Remove unnecessary include #Patch Set 3 : Removed wrong include #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update type_traits in base/values_unittest.cc BUG=554293 ========== to ========== Update type_traits in base/values_unittest.cc Following last week's sysroot update more type_traits became available on all platforms. This change updates the specific checks in base/values_unittest.cc BUG=554293 ==========
jdoerrie@chromium.org changed reviewers: + brettw@chromium.org
Hi Brett, please review.
Oh yay, that was fast.
lgtm
The CQ bit was checked by jdoerrie@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jdoerrie@chromium.org
The CQ bit was checked by jdoerrie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2791193003/#ps20001 (title: "Remove unnecessary include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jdoerrie@chromium.org
The CQ bit was checked by jdoerrie@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2791193003/#ps40001 (title: "Removed wrong include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491294161741590,
"parent_rev": "970a4c9930710171b68590310689da52ac6f02e7", "commit_rev":
"9d47e9ad141cc0c8d05066751cf748f0fcbc55da"}
Message was sent while issue was closed.
Description was changed from ========== Update type_traits in base/values_unittest.cc Following last week's sysroot update more type_traits became available on all platforms. This change updates the specific checks in base/values_unittest.cc BUG=554293 ========== to ========== Update type_traits in base/values_unittest.cc Following last week's sysroot update more type_traits became available on all platforms. This change updates the specific checks in base/values_unittest.cc BUG=554293 Review-Url: https://codereview.chromium.org/2791193003 Cr-Commit-Position: refs/heads/master@{#461664} Committed: https://chromium.googlesource.com/chromium/src/+/9d47e9ad141cc0c8d05066751cf7... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9d47e9ad141cc0c8d05066751cf7... |
