Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2791123002: Remove static_casts from PermissionUmaUtil histogram calls. (Closed)

Created:
3 years, 8 months ago by dominickn
Modified:
3 years, 8 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove static_casts from PermissionUmaUtil histogram calls. Histograms that use enum classes no longer require recorded values to be static_cast'd to int. This CL removes static_cast<int> calls in permissions code. Histogram tests still require explicit cast out of enum classes, so these are not removed by this CL. BUG=638076 Review-Url: https://codereview.chromium.org/2791123002 Cr-Commit-Position: refs/heads/master@{#461369} Committed: https://chromium.googlesource.com/chromium/src/+/669662b980b9fc6e91c8c525e6a0f4e14ab002c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -52 lines) Patch
M chrome/browser/permissions/permission_uma_util.cc View 9 chunks +34 lines, -52 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dominickn
PTAL, thanks!
3 years, 8 months ago (2017-04-03 00:17:33 UTC) #4
raymes
lgtm, thanks for the cleanup :) I'm not quite sure why the casts aren't needed ...
3 years, 8 months ago (2017-04-03 03:53:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791123002/1
3 years, 8 months ago (2017-04-03 03:59:35 UTC) #9
dominickn
On 2017/04/03 03:53:07, raymes (OOO until April 10) wrote: > lgtm, thanks for the cleanup ...
3 years, 8 months ago (2017-04-03 04:00:10 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 04:06:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/669662b980b9fc6e91c8c525e6a0...

Powered by Google App Engine
This is Rietveld 408576698