[subresource_filter] replace custom infobar icon with chrome icon

[subresource_filter] replace custom infobar icon with chrome icon

Note that this only changes the icon for the mini infobar, not for
the entire feature (content settings, desktop UI, etc).

BUG=689992
Review-Url: https://codereview.chromium.org/2791093002
Cr-Commit-Position: refs/heads/master@{#463317}
Committed: https://chromium.googlesource.com/chromium/src/+/8088cc1ba912e866ea7c5daef7a7b4beba74525c

[Charlie Harrison, 2017-04-01 21:56:25]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 21:56:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-04-01 22:27:35]

Description was changed from

==========
Replace subresource filter infobar icon with chrome icon

BUG=689992
==========

to

==========
[subresource_filter] replace custom infobar icon with chrome icon

BUG=689992
==========

[commit-bot: I haz the power, 2017-04-01 22:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 22:34:04]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2017-04-02 20:28:42]

csharrison@chromium.org changed reviewers:
+ engedy@chromium.org

[Charlie Harrison, 2017-04-02 20:28:43]

engedy: PTAL?

[engedy, 2017-04-03 13:36:19]

Hang on, let me double-check if this is the icon we want.

[engedy, 2017-04-03 14:35:50]

LGTM now that I understand that this affects only the mini-infobar on Android.

[Charlie Harrison, 2017-04-03 14:39:02]

On 2017/04/03 14:35:50, engedy wrote:
> LGTM now that I understand that this affects only the mini-infobar on Android.

Thanks, let me update the description to be a bit clearer.

[Charlie Harrison, 2017-04-03 14:39:43]

Description was changed from

==========
[subresource_filter] replace custom infobar icon with chrome icon

BUG=689992
==========

to

==========
[subresource_filter] replace custom infobar icon with chrome icon

Note that this only changes the icon for the mini infobar, not for
the entire feature (content settings, desktop UI, etc).

BUG=689992
==========

[Charlie Harrison, 2017-04-03 14:43:02]

csharrison@chromium.org changed reviewers:
+ dtrainor@chromium.org, mikecase@chromium.org

[Charlie Harrison, 2017-04-03 14:43:02]

+dtrainor, would you PTAL at java/res and resource_id.h?


+mikecase, would you at the build/android/lint/suppressions.xml removal?

[David Trainor- moved to gerrit, 2017-04-03 17:53:09]

lgtm

[Charlie Harrison, 2017-04-10 12:47:56]

mikecase: friendly ping for trivial suppression removal

[mikecase (-- gone --), 2017-04-10 16:42:52]

lgtm

[Charlie Harrison, 2017-04-10 16:46:51]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:47:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:53:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491842811158050, "parent_rev":
"06e9b5a6a5649e4d842f40ad667554c58dc26c29", "commit_rev":
"8088cc1ba912e866ea7c5daef7a7b4beba74525c"}

[commit-bot: I haz the power, 2017-04-10 17:54:11]

Description was changed from

==========
[subresource_filter] replace custom infobar icon with chrome icon

Note that this only changes the icon for the mini infobar, not for
the entire feature (content settings, desktop UI, etc).

BUG=689992
==========

to

==========
[subresource_filter] replace custom infobar icon with chrome icon

Note that this only changes the icon for the mini infobar, not for
the entire feature (content settings, desktop UI, etc).

BUG=689992

Review-Url: https://codereview.chromium.org/2791093002
Cr-Commit-Position: refs/heads/master@{#463317}
Committed:
https://chromium.googlesource.com/chromium/src/+/8088cc1ba912e866ea7c5daef7a7...
==========

[commit-bot: I haz the power, 2017-04-10 17:54:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8088cc1ba912e866ea7c5daef7a7...