Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2791023002:
FP16 mode gamma fix (Closed)
DescriptionFP16 mode gamma fix
Works around a bug in nvidia drivers which doesn't do gamma conversions
even when we asked for it. The workaround is to keep the intermediate
texture in gamma 2.2 and let the compositor figure out how to draw it
correctly.
Also fix an minor unrelated issue in color_space_win.cc
Really we shouldn't be using fp16 at all in this mode, but I haven't figured
out a reliable signal for the bit depth yet.
BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2791023002
Cr-Commit-Position: refs/heads/master@{#461623}
Committed: https://chromium.googlesource.com/chromium/src/+/75705ebbf91265a8db5218d1acff3f1026777e9e
Patch Set 1 #Patch Set 2 : bugfix #
Messages
Total messages: 35 (21 generated)
Description was changed from ========== FP16 mode gamma fix Works around a bug in nvidia drivers which doesn't do gamma conversions even when we asked for it. The workaround is to keep the intermediate texture in gamma 2.2 and let the compositor figure out how to draw it correctly. Really we shouldn't be using fp16 at all in this mode, but I haven't figured out a reliable signal for the bit depth yet. BUG=682416 ========== to ========== FP16 mode gamma fix Works around a bug in nvidia drivers which doesn't do gamma conversions even when we asked for it. The workaround is to keep the intermediate texture in gamma 2.2 and let the compositor figure out how to draw it correctly. Really we shouldn't be using fp16 at all in this mode, but I haven't figured out a reliable signal for the bit depth yet. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== FP16 mode gamma fix Works around a bug in nvidia drivers which doesn't do gamma conversions even when we asked for it. The workaround is to keep the intermediate texture in gamma 2.2 and let the compositor figure out how to draw it correctly. Really we shouldn't be using fp16 at all in this mode, but I haven't figured out a reliable signal for the bit depth yet. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== FP16 mode gamma fix Works around a bug in nvidia drivers which doesn't do gamma conversions even when we asked for it. The workaround is to keep the intermediate texture in gamma 2.2 and let the compositor figure out how to draw it correctly. Also fix an minor unrelated issue in color_space_win.cc Really we shouldn't be using fp16 at all in this mode, but I haven't figured out a reliable signal for the bit depth yet. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
hubbe@chromium.org changed reviewers: + jbauman@chromium.org
hubbe@chromium.org changed reviewers: + ccameron@chromium.org
lgtm
The CQ bit was unchecked by hubbe@chromium.org
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2017/03/31 22:41:34, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) OOps, still need OWNERS. ccameron?
On 2017/03/31 22:44:00, hubbe wrote: > On 2017/03/31 22:41:34, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > OOps, still need OWNERS. ccameron? ccameron: ping?
lgtm
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org, ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/2791023002/#ps20001 (title: "bugfix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491274721265470,
"parent_rev": "74652feeb6f79d63d84a2859b8f7f0a04c403d80", "commit_rev":
"75705ebbf91265a8db5218d1acff3f1026777e9e"}
Message was sent while issue was closed.
Description was changed from ========== FP16 mode gamma fix Works around a bug in nvidia drivers which doesn't do gamma conversions even when we asked for it. The workaround is to keep the intermediate texture in gamma 2.2 and let the compositor figure out how to draw it correctly. Also fix an minor unrelated issue in color_space_win.cc Really we shouldn't be using fp16 at all in this mode, but I haven't figured out a reliable signal for the bit depth yet. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== FP16 mode gamma fix Works around a bug in nvidia drivers which doesn't do gamma conversions even when we asked for it. The workaround is to keep the intermediate texture in gamma 2.2 and let the compositor figure out how to draw it correctly. Also fix an minor unrelated issue in color_space_win.cc Really we shouldn't be using fp16 at all in this mode, but I haven't figured out a reliable signal for the bit depth yet. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2791023002 Cr-Commit-Position: refs/heads/master@{#461623} Committed: https://chromium.googlesource.com/chromium/src/+/75705ebbf91265a8db5218d1acff... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/75705ebbf91265a8db5218d1acff... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
