Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc

Issue 2790993003: Add Generic Implementation of ClipboardRecentContent (Closed)
Patch Set: tested interactively; works. removed field trial force-enable code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
diff --git a/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc b/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1101c5e92e888b71677bb1db27dda44e13afd278
--- /dev/null
+++ b/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
@@ -0,0 +1,126 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/open_from_clipboard/clipboard_recent_content_generic.h"
+
+#include <memory>
+#include <utility>
+
+#include "base/strings/string16.h"
+#include "base/time/time.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/test/test_clipboard.h"
+#include "url/gurl.h"
+
+class ClipboardRecentContentGenericTest : public testing::Test {
+ protected:
+ void SetUp() override {
+ test_clipboard_ = new ui::TestClipboard;
+ std::unique_ptr<ui::Clipboard> clipboard(test_clipboard_);
+ ui::Clipboard::SetClipboardForCurrentThread(std::move(clipboard));
+ }
+
+ void TearDown() override {
+ ui::Clipboard::DestroyClipboardForCurrentThread();
+ }
+
+ ui::TestClipboard* test_clipboard_;
+};
+
+TEST_F(ClipboardRecentContentGenericTest, RecognizesURLs) {
+ struct {
+ std::string clipboard;
+ const bool expected_get_recent_url_value;
+ } test_data[] = {
+ {"www", false},
+ {"query string", false},
+ {"www.example.com", false},
+ {"http://www.example.com/", true},
+ // The missing trailing slash shouldn't matter.
+ {"http://www.example.com", true},
+ {"https://another-example.com/", true},
+ {"http://example.com/with-path/", true},
+ {"about:version", true},
+ {"data:,Hello%2C%20World!", true},
+ // Certain schemes are not eligible to be suggested.
+ {"ftp://example.com/", false},
+ // Leading and trailing spaces are okay, other spaces not.
+ {" http://leading.com", true},
+ {" http://both.com/trailing ", true},
+ {"http://malformed url", false},
+ {"http://another.com/malformed url", false},
+ // Internationalized domain names should work.
+ {"http://xn--c1yn36f", true},
+ {" http://xn--c1yn36f/path ", true},
+ {"http://xn--c1yn36f extra ", false},
+ {"http://點看", true},
+ {"http://點看/path", true},
+ {" http://點看/path ", true},
+ {" http://點看/path extra word", false},
+ };
+
+ ClipboardRecentContentGeneric recent_content;
+ base::Time now = base::Time::Now();
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
+ test_clipboard_->WriteText(test_data[i].clipboard.data(),
+ test_data[i].clipboard.length());
+ test_clipboard_->SetClipboardLastModifiedTime(
+ now - base::TimeDelta::FromSeconds(10));
+ GURL url;
+ EXPECT_EQ(test_data[i].expected_get_recent_url_value,
+ recent_content.GetRecentURLFromClipboard(&url))
+ << "for input " << test_data[i].clipboard;
+ }
+}
+
+TEST_F(ClipboardRecentContentGenericTest, OlderURLsNotSuggested) {
+ ClipboardRecentContentGeneric recent_content;
+ base::Time now = base::Time::Now();
+ std::string text = "http://example.com/";
+ test_clipboard_->WriteText(text.data(), text.length());
+ test_clipboard_->SetClipboardLastModifiedTime(
+ now - base::TimeDelta::FromSeconds(10));
+ GURL url;
+ EXPECT_TRUE(recent_content.GetRecentURLFromClipboard(&url));
+ // If the last modified time is days ago, the URL shouldn't be suggested.
+ test_clipboard_->SetClipboardLastModifiedTime(now -
+ base::TimeDelta::FromDays(2));
+ EXPECT_FALSE(recent_content.GetRecentURLFromClipboard(&url));
+}
+
+TEST_F(ClipboardRecentContentGenericTest, GetClipboardContentAge) {
+ ClipboardRecentContentGeneric recent_content;
+ base::Time now = base::Time::Now();
+ std::string text = " whether URL or not should not matter here.";
+ test_clipboard_->WriteText(text.data(), text.length());
+ test_clipboard_->SetClipboardLastModifiedTime(
+ now - base::TimeDelta::FromSeconds(32));
+ base::TimeDelta age = recent_content.GetClipboardContentAge();
+ // It's possible the GetClipboardContentAge() took some time, so allow a
+ // little slop (5 seconds) in this comparison; don't check for equality.
+ EXPECT_LT(age - base::TimeDelta::FromSeconds(32),
+ base::TimeDelta::FromSeconds(5));
+}
+
+TEST_F(ClipboardRecentContentGenericTest, SuppressClipboardContent) {
+ // Make sure the URL is suggested.
+ ClipboardRecentContentGeneric recent_content;
+ base::Time now = base::Time::Now();
+ std::string text = "http://example.com/";
+ test_clipboard_->WriteText(text.data(), text.length());
+ test_clipboard_->SetClipboardLastModifiedTime(
+ now - base::TimeDelta::FromSeconds(10));
+ GURL url;
+ EXPECT_TRUE(recent_content.GetRecentURLFromClipboard(&url));
+
+ // After suppressing it, it shouldn't be suggested.
+ recent_content.SuppressClipboardContent();
+ EXPECT_FALSE(recent_content.GetRecentURLFromClipboard(&url));
+
+ // If the clipboard changes, even if to the same thing again, the content
+ // should be suggested again.
+ test_clipboard_->WriteText(text.data(), text.length());
+ test_clipboard_->SetClipboardLastModifiedTime(now);
+ EXPECT_TRUE(recent_content.GetRecentURLFromClipboard(&url));
+}

Powered by Google App Engine
This is Rietveld 408576698