Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: components/open_from_clipboard/clipboard_recent_content_generic.cc

Issue 2790993003: Add Generic Implementation of ClipboardRecentContent (Closed)
Patch Set: tested interactively; works. removed field trial force-enable code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/open_from_clipboard/clipboard_recent_content_generic.cc
diff --git a/components/open_from_clipboard/clipboard_recent_content_generic.cc b/components/open_from_clipboard/clipboard_recent_content_generic.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4218ce1f46a06cab6a508622bc88b91a1f0e6442
--- /dev/null
+++ b/components/open_from_clipboard/clipboard_recent_content_generic.cc
@@ -0,0 +1,72 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/open_from_clipboard/clipboard_recent_content_generic.h"
+
+#include "base/strings/string_util.h"
+#include "ui/base/clipboard/clipboard.h"
+
+ClipboardRecentContentGeneric::ClipboardRecentContentGeneric() {}
+
+bool ClipboardRecentContentGeneric::GetRecentURLFromClipboard(GURL* url) {
+ ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
+ base::Time last_modified_time = clipboard->GetClipboardLastModifiedTime();
+ if (!last_modified_time_to_suppress_.is_null() &&
+ (last_modified_time == last_modified_time_to_suppress_))
+ return false;
+
+ if (GetClipboardContentAge() > kMaximumAgeOfClipboard)
+ return false;
+
+ // Get and clean up the clipboard before processing.
+ std::string gurl_string;
+ clipboard->ReadAsciiText(ui::CLIPBOARD_TYPE_COPY_PASTE, &gurl_string);
+ base::TrimWhitespaceASCII(gurl_string, base::TrimPositions::TRIM_ALL,
+ &gurl_string);
+
+ // Interpret the clipboard as a URL if possible.
+ DCHECK(url);
+ // If there is mid-string whitespace, don't attempt to interpret the string
+ // as a URL. (Otherwise gurl will happily try to convert
+ // "http://example.com extra words" into "http://example.com%20extra%20words",
+ // which is not likely to be a useful or intended destination.)
+ if (gurl_string.find_first_of(base::kWhitespaceASCII) != std::string::npos)
+ return false;
+ if (!gurl_string.empty()) {
+ *url = GURL(gurl_string);
+ } else {
+ // Fall back to unicode / UTF16, as some URLs may use international domain
+ // names, not punycode.
+ base::string16 gurl_string16;
+ clipboard->ReadText(ui::CLIPBOARD_TYPE_COPY_PASTE, &gurl_string16);
+ base::TrimWhitespace(gurl_string16, base::TrimPositions::TRIM_ALL,
+ &gurl_string16);
+ if (gurl_string16.find_first_of(base::kWhitespaceUTF16) !=
+ std::string::npos)
+ return false;
+ if (!gurl_string16.empty())
+ *url = GURL(gurl_string16);
+ }
+ return url->is_valid() && IsAppropriateSuggestion(*url);
+}
+
+base::TimeDelta ClipboardRecentContentGeneric::GetClipboardContentAge() const {
+ const base::Time last_modified_time =
+ ui::Clipboard::GetForCurrentThread()->GetClipboardLastModifiedTime();
+ const base::Time now = base::Time::Now();
+ // In case of system clock change, assume the last modified time is now.
+ // (Don't return a negative age, i.e., a time in the future.)
+ if (last_modified_time > now)
+ return base::TimeDelta();
+ return now - last_modified_time;
+}
+
+void ClipboardRecentContentGeneric::SuppressClipboardContent() {
+ // User cleared the user data. The pasteboard entry must be removed from the
+ // omnibox list. Do this by suppressing all clipboard content with the
+ // current clipboard content's time. Then we only suggest the clipboard
+ // content later if the time changed.
+ last_modified_time_to_suppress_ =
+ ui::Clipboard::GetForCurrentThread()->GetClipboardLastModifiedTime();
+}

Powered by Google App Engine
This is Rietveld 408576698