MD Settings: Tweak margin of "Trust settings" header.

MD Settings: Tweak margin of "Trust settings" header.

BUG=700126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2790993002
Cr-Commit-Position: refs/heads/master@{#461244}
Committed: https://chromium.googlesource.com/chromium/src/+/cc16b8ab7df17b1462d98640d6dd8cb1ccd2dbce

[dpapad, 2017-03-31 19:19:42]

Description was changed from

==========
MD Settings: Tweak margin of "Trust settings" header.

BUG=700126
==========

to

==========
MD Settings: Tweak margin of "Trust settings" header.

BUG=700126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-03-31 19:23:15]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 19:24:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-03-31 19:24:16]

dpapad@chromium.org changed reviewers:
+ scottchen@chromium.org

[dpapad, 2017-03-31 19:24:17]

Before/after screenshots: http://imgur.com/a/fuyxc

[scottchen, 2017-03-31 19:41:06]

On 2017/03/31 19:24:17, dpapad wrote:
> Before/after screenshots: http://imgur.com/a/fuyxc

lgtm, but margin: 15px seems kind of arbitrary. Alternatively you could consider
giving each of those div the .settings-box class (and .two-line for the first
div) so that their top and bottom spacing is more consistent with other stuff.

[dpapad, 2017-03-31 20:33:35]

On 2017/03/31 at 19:41:06, scottchen wrote:
> On 2017/03/31 19:24:17, dpapad wrote:
> > Before/after screenshots: http://imgur.com/a/fuyxc
> 
> lgtm, but margin: 15px seems kind of arbitrary. Alternatively you could
consider giving each of those div the .settings-box class (and .two-line for the
first div) so that their top and bottom spacing is more consistent with other
stuff.

The 15px separation between dialog items is coming from the dialog's spec
(although I could not find it with a quick search). I prefer to not use
settings-box within a dilaog. My understanding is that settings-box was
originally designed for elements that reside within "white card" meaning a top
level page or a subpage, but not for the contents of the dialog.

[dpapad, 2017-03-31 20:33:53]

dpapad@chromium.org changed reviewers:
+ hcarmona@chromium.org

[dpapad, 2017-03-31 20:33:54]

+hcarmona: Need a review from a committer too. Thanks.

[hcarmona, 2017-03-31 20:42:01]

lgtm

[dpapad, 2017-03-31 20:50:38]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-03-31 20:50:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottchen@chromium.org, hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/2790993002/#ps20001
(title: "Remove unnecessary space.")

[commit-bot: I haz the power, 2017-03-31 20:51:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 22:06:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490993438829780,
"parent_rev": "70395486c5552329b3cd1e9658d017128840431e", "commit_rev":
"cc16b8ab7df17b1462d98640d6dd8cb1ccd2dbce"}

[commit-bot: I haz the power, 2017-03-31 22:06:48]

Description was changed from

==========
MD Settings: Tweak margin of "Trust settings" header.

BUG=700126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Tweak margin of "Trust settings" header.

BUG=700126
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2790993002
Cr-Commit-Position: refs/heads/master@{#461244}
Committed:
https://chromium.googlesource.com/chromium/src/+/cc16b8ab7df17b1462d98640d6dd...
==========

[commit-bot: I haz the power, 2017-03-31 22:06:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cc16b8ab7df17b1462d98640d6dd...