Makes AshTestImpl::Create create the right impl based on config

Makes AshTestImpl::Create create the right impl based on config

Previously there was a factory function that was expected to be
compiled into the target for the creation. Now that AshTestHelper
knows the config the factory function can be shared. This is necessary
for ash_unittests so that it can work with and without --mus.

Also note that AshTestImpl should go away eventually.

BUG=705715
TEST=test only changes
R=msw@chromium.org, reveman@chromium.org

Review-Url: https://codereview.chromium.org/2790903002
Cr-Commit-Position: refs/heads/master@{#461195}
Committed: https://chromium.googlesource.com/chromium/src/+/be0a78336df511783b675d9356631f8a6521f3e4

[sky, 2017-03-31 15:22:53]

reveman: exo
msw: the rest

[sky, 2017-03-31 15:22:56]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 15:23:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2017-03-31 16:15:44]

lgtm

[commit-bot: I haz the power, 2017-03-31 16:21:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:21:34]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[msw, 2017-03-31 16:27:13]

nice, lgtm with optional nits

https://codereview.chromium.org/2790903002/diff/1/ash/test/BUILD.gn
File ash/test/BUILD.gn (left):

https://codereview.chromium.org/2790903002/diff/1/ash/test/BUILD.gn#oldcode17
ash/test/BUILD.gn:17: "//base",
optional nit: move this generic //base dep to test_support_common?

https://codereview.chromium.org/2790903002/diff/1/ash/test/ash_test_helper.h
File ash/test/ash_test_helper.h (right):

https://codereview.chromium.org/2790903002/diff/1/ash/test/ash_test_helper.h#...
ash/test/ash_test_helper.h:68: // Returns the configuration tests are run in.
nit: "that tests", optionally mention mus to clarify the generic terminology?

[sky, 2017-03-31 17:37:22]

https://codereview.chromium.org/2790903002/diff/1/ash/test/BUILD.gn
File ash/test/BUILD.gn (left):

https://codereview.chromium.org/2790903002/diff/1/ash/test/BUILD.gn#oldcode17
ash/test/BUILD.gn:17: "//base",
On 2017/03/31 16:27:13, msw wrote:
> optional nit: move this generic //base dep to test_support_common?

Done.

https://codereview.chromium.org/2790903002/diff/1/ash/test/ash_test_helper.h
File ash/test/ash_test_helper.h (right):

https://codereview.chromium.org/2790903002/diff/1/ash/test/ash_test_helper.h#...
ash/test/ash_test_helper.h:68: // Returns the configuration tests are run in.
On 2017/03/31 16:27:13, msw wrote:
> nit: "that tests", optionally mention mus to clarify the generic terminology?

Done.

[sky, 2017-03-31 17:37:28]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-31 17:37:29]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2790903002/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2017-03-31 17:37:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 20:02:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490981848839930,
"parent_rev": "532ac77836647714a0ed93c871b4a0b75159fcaa", "commit_rev":
"be0a78336df511783b675d9356631f8a6521f3e4"}

[commit-bot: I haz the power, 2017-03-31 20:11:40]

Description was changed from

==========
Makes AshTestImpl::Create create the right impl based on config

Previously there was a factory function that was expected to be
compiled into the target for the creation. Now that AshTestHelper
knows the config the factory function can be shared. This is necessary
for ash_unittests so that it can work with and without --mus.

Also note that AshTestImpl should go away eventually.

BUG=705715
TEST=test only changes
R=msw@chromium.org, reveman@chromium.org
==========

to

==========
Makes AshTestImpl::Create create the right impl based on config

Previously there was a factory function that was expected to be
compiled into the target for the creation. Now that AshTestHelper
knows the config the factory function can be shared. This is necessary
for ash_unittests so that it can work with and without --mus.

Also note that AshTestImpl should go away eventually.

BUG=705715
TEST=test only changes
R=msw@chromium.org, reveman@chromium.org

Review-Url: https://codereview.chromium.org/2790903002
Cr-Commit-Position: refs/heads/master@{#461195}
Committed:
https://chromium.googlesource.com/chromium/src/+/be0a78336df511783b675d935663...
==========

[commit-bot: I haz the power, 2017-03-31 20:11:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be0a78336df511783b675d935663...