Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2790893004: Delete Android content detectors. (Closed)

Created:
3 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, Peter Beverloo, shuchen+watch_chromium.org, James Su, Theresa, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete Android content detectors. This feature has been replaced by contextual search, which provides a superset of the functionality with a better UI. It's been disabled behind a flag for one release and is now ready for removal. Note that content/common/android/address_parser.cc is not deleted, because it's still in use by WebView.findAddress() public API. BUG=664307 Review-Url: https://codereview.chromium.org/2790893004 Cr-Commit-Position: refs/heads/master@{#462596} Committed: https://chromium.googlesource.com/chromium/src/+/b7d91597c0438dc21291f862ce0dd920abd11bc4

Patch Set 1 #

Patch Set 2 : Presubmit and delete test data #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2183 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java View 1 2 chunks +0 lines, -14 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java View 1 2 4 chunks +0 lines, -151 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabViewAndroidDelegate.java View 1 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/BUILD.gn View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +0 lines, -3 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java View 1 2 1 chunk +0 lines, -119 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java View 1 chunk +0 lines, -54 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionActivityTestRule.java View 1 chunk +0 lines, -75 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java View 1 chunk +0 lines, -77 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestCommon.java View 1 chunk +0 lines, -123 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/EmailAddressDetectionTest.java View 1 chunk +0 lines, -46 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java View 1 chunk +0 lines, -221 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
D content/renderer/android/address_detector.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/renderer/android/address_detector.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D content/renderer/android/content_detector.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/renderer/android/content_detector.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D content/renderer/android/email_detector.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/renderer/android/email_detector.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D content/renderer/android/email_detector_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D content/renderer/android/phone_number_detector.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/renderer/android/phone_number_detector.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D content/renderer/android/phone_number_detector_unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 5 chunks +0 lines, -22 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 5 chunks +0 lines, -76 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellViewAndroidDelegate.java View 1 2 chunks +0 lines, -26 lines 0 comments Download
M content/test/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/android/content_detection/click_listeners.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D content/test/data/android/content_detection/email.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D content/test/data/android/content_detection/empty.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/android/content_detection/geo_address_limits.html View 1 1 chunk +0 lines, -25 lines 0 comments Download
D content/test/data/android/content_detection/geo_address_multiple.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D content/test/data/android/content_detection/geo_address_real.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
D content/test/data/android/content_detection/geo_address_special_chars.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D content/test/data/android/content_detection/geo_address_split.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D content/test/data/android/content_detection/phone_international.html View 1 1 chunk +0 lines, -39 lines 0 comments Download
D content/test/data/android/content_detection/phone_local.html View 1 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 7 chunks +0 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 2 chunks +0 lines, -122 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/content_listeners.html View 1 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/content_listeners_iframe.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 2 chunks +0 lines, -19 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java View 1 3 chunks +0 lines, -37 lines 0 comments Download
M ui/android/view_android.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M ui/android/view_android.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
aelias_OOO_until_Jul13
PTAL, alexmos@ for content/common/ and content/browser/web_contents/ sgurun@ for android_webview/ tedchoc@ for chrome/ and ui/android/ tsepez@ ...
3 years, 8 months ago (2017-04-05 21:25:59 UTC) #13
Tom Sepez
lgtm
3 years, 8 months ago (2017-04-05 21:31:59 UTC) #14
sgurun-gerrit only
lgtm
3 years, 8 months ago (2017-04-06 03:08:47 UTC) #17
Ted C
On 2017/04/06 03:08:47, sgurun wrote: > lgtm lgtm
3 years, 8 months ago (2017-04-06 05:16:31 UTC) #18
alexmos
LGTM
3 years, 8 months ago (2017-04-06 16:20:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790893004/40001
3 years, 8 months ago (2017-04-06 19:15:34 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:58:30 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b7d91597c0438dc21291f862ce0d...

Powered by Google App Engine
This is Rietveld 408576698