Add support for rebaselining for a port from a non-corresponding builder.

Add support for rebaselining for a port from a non-corresponding builder.

This CL changes TestBaselineSet to store port names as well as builds,
and makes it so that the rebaseline method, when given constructing a
list of commands to invoke for a given TestBaselineSet, the port name
is according to the TestBaselineSet and doesn't necessarily need to
correspond to the builder name.

After this change, I believe that the only change left before
rebaseline-cl supports rebaselining with only some try bot results
available is to change the way that TestBaselineSets are created
in rebaseline_cl.py.

BUG=673966
Review-Url: https://codereview.chromium.org/2790863002
Cr-Commit-Position: refs/heads/master@{#461980}
Committed: https://chromium.googlesource.com/chromium/src/+/339734d88bb8df1cc19b7f0bee7cdcf0645fb1ef

[qyearsley, 2017-03-31 00:31:13]

qyearsley@chromium.org changed reviewers:
+ wkorman@chromium.org

[qyearsley, 2017-03-31 00:54:45]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 00:55:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 01:57:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 01:57:29]

Dry run: This issue passed the CQ dry run.

[wkorman, 2017-04-03 20:41:52]

lgtm

https://codereview.chromium.org/2790863002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
(right):

https://codereview.chromium.org/2790863002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py:650: for
test, build, _ in test_baseline_set:
Is this ok re: we won't start doing multiples of tests where they are present in
duplicate test/build configs across ports? Similar for above.

[qyearsley, 2017-04-04 18:56:45]

https://codereview.chromium.org/2790863002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
(right):

https://codereview.chromium.org/2790863002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py:650: for
test, build, _ in test_baseline_set:
On 2017/04/03 at 20:41:52, wkorman wrote:
> Is this ok re: we won't start doing multiples of tests where they are present
in duplicate test/build configs across ports? Similar for above.

Good idea to check this; right now it looks like it should be OK:
 - in _possible_baseline_paths, we're adding to a set, so duplicates shouldn't
be added.
 - in _optimize_baselines, we're updating an entry to a dictionary, and updating
multiple times should be OK.
 - in rebaseline, we're building a set, so duplicates shouldn't be added.

[qyearsley, 2017-04-05 03:47:04]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-04-05 03:47:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 04:44:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491364024612270, "parent_rev":
"41f44b42ba111f77d99f545f3a64022d28577638", "commit_rev":
"339734d88bb8df1cc19b7f0bee7cdcf0645fb1ef"}

[commit-bot: I haz the power, 2017-04-05 04:45:29]

Description was changed from

==========
Add support for rebaselining for a port from a non-corresponding builder.

This CL changes TestBaselineSet to store port names as well as builds,
and makes it so that the rebaseline method, when given constructing a
list of commands to invoke for a given TestBaselineSet, the port name
is according to the TestBaselineSet and doesn't necessarily need to
correspond to the builder name.

After this change, I believe that the only change left before
rebaseline-cl supports rebaselining with only some try bot results
available is to change the way that TestBaselineSets are created
in rebaseline_cl.py.

BUG=673966
==========

to

==========
Add support for rebaselining for a port from a non-corresponding builder.

This CL changes TestBaselineSet to store port names as well as builds,
and makes it so that the rebaseline method, when given constructing a
list of commands to invoke for a given TestBaselineSet, the port name
is according to the TestBaselineSet and doesn't necessarily need to
correspond to the builder name.

After this change, I believe that the only change left before
rebaseline-cl supports rebaselining with only some try bot results
available is to change the way that TestBaselineSets are created
in rebaseline_cl.py.

BUG=673966

Review-Url: https://codereview.chromium.org/2790863002
Cr-Commit-Position: refs/heads/master@{#461980}
Committed:
https://chromium.googlesource.com/chromium/src/+/339734d88bb8df1cc19b7f0bee7c...
==========

[commit-bot: I haz the power, 2017-04-05 04:45:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/339734d88bb8df1cc19b7f0bee7c...