Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2790823003: net: calculate dns header size only once per query/response (Closed)

Created:
3 years, 8 months ago by tfarina
Modified:
3 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

net: calculate dns header size only once per query/response Introduce a constant for this, so it is done only once, which leads to shorter code in some places. BUG=None TEST=net_unittests R=eroman@chromium.org Review-Url: https://codereview.chromium.org/2790823003 Cr-Commit-Position: refs/heads/master@{#461574} Committed: https://chromium.googlesource.com/chromium/src/+/8dab5e7ae866d7996e66f1b76b0b599541ea9fdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M net/dns/dns_query.cc View 3 chunks +13 lines, -10 lines 0 comments Download
M net/dns/dns_response.cc View 3 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tfarina
3 years, 8 months ago (2017-03-31 11:50:42 UTC) #6
eroman
lgtm
3 years, 8 months ago (2017-04-03 19:43:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790823003/1
3 years, 8 months ago (2017-04-03 22:07:39 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 23:18:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8dab5e7ae866d7996e66f1b76b0b...

Powered by Google App Engine
This is Rietveld 408576698