Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Issue 2790813002: DevTools: ViewContainer shouldn't be a tab stop (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
hans.hillen, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: ViewContainer shouldn't be a tab stop ViewContainers had tabIndex=0, so when tabbing around devtools they recieved focus for no good reason. BUG=706699 Review-Url: https://codereview.chromium.org/2790813002 Cr-Commit-Position: refs/heads/master@{#461046} Committed: https://chromium.googlesource.com/chromium/src/+/048c6e39319b24da880452acd1f96ea8c78e515d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/inspector/elements/elements-tab-stops.html View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/elements-tab-stops-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
einbinder
ptal
3 years, 8 months ago (2017-03-30 22:28:10 UTC) #2
einbinder
3 years, 8 months ago (2017-03-30 23:18:58 UTC) #4
pfeldman
lgtm
3 years, 8 months ago (2017-03-30 23:46:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790813002/1
3 years, 8 months ago (2017-03-30 23:52:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/339841)
3 years, 8 months ago (2017-03-31 00:56:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790813002/1
3 years, 8 months ago (2017-03-31 03:58:01 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 05:12:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/048c6e39319b24da880452acd1f9...

Powered by Google App Engine
This is Rietveld 408576698