chrome/browser/ui/views/translate/translate_bubble_view.cc - Issue 2790773002: Cleanup MenuRunner API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/translate/translate_bubble_view.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc

index 7c6d8c650b947256c5ca24b0f6ccf89bfee496c4..5febd678af0e7795af8d5ff26ef457aa049429be 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc

@@ -281,8 +281,8 @@ void TranslateBubbleView::OnMenuButtonClicked(views::MenuButton* source,

DenialMenuItem::NEVER_TRANSLATE_SITE,

IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_SITE);

- denial_menu_runner_.reset(new views::MenuRunner(denial_menu_model_.get(),

- views::MenuRunner::ASYNC));

+ denial_menu_runner_.reset(

+ new views::MenuRunner(denial_menu_model_.get(), 0));

}

gfx::Rect screen_bounds = source->GetBoundsInScreen();

denial_menu_runner_->RunMenuAt(source->GetWidget(), source, screen_bounds,