Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h" 5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 l10n_util::GetStringFUTF16( 274 l10n_util::GetStringFUTF16(
275 IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_LANG, 275 IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_LANG,
276 model_->GetLanguageNameAt(model_->GetOriginalLanguageIndex()))); 276 model_->GetLanguageNameAt(model_->GetOriginalLanguageIndex())));
277 277
278 denial_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR); 278 denial_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);
279 279
280 denial_menu_model_->AddItemWithStringId( 280 denial_menu_model_->AddItemWithStringId(
281 DenialMenuItem::NEVER_TRANSLATE_SITE, 281 DenialMenuItem::NEVER_TRANSLATE_SITE,
282 IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_SITE); 282 IDS_TRANSLATE_BUBBLE_NEVER_TRANSLATE_SITE);
283 283
284 denial_menu_runner_.reset(new views::MenuRunner(denial_menu_model_.get(), 284 denial_menu_runner_.reset(
285 views::MenuRunner::ASYNC)); 285 new views::MenuRunner(denial_menu_model_.get(), 0));
286 } 286 }
287 gfx::Rect screen_bounds = source->GetBoundsInScreen(); 287 gfx::Rect screen_bounds = source->GetBoundsInScreen();
288 denial_menu_runner_->RunMenuAt(source->GetWidget(), source, screen_bounds, 288 denial_menu_runner_->RunMenuAt(source->GetWidget(), source, screen_bounds,
289 views::MENU_ANCHOR_TOPRIGHT, 289 views::MENU_ANCHOR_TOPRIGHT,
290 ui::MENU_SOURCE_MOUSE); 290 ui::MENU_SOURCE_MOUSE);
291 } 291 }
292 292
293 bool TranslateBubbleView::IsCommandIdChecked(int command_id) const { 293 bool TranslateBubbleView::IsCommandIdChecked(int command_id) const {
294 return false; 294 return false;
295 } 295 }
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
946 base::string16 label; 946 base::string16 label;
947 if (model_->IsPageTranslatedInCurrentLanguages()) 947 if (model_->IsPageTranslatedInCurrentLanguages())
948 label = l10n_util::GetStringUTF16(IDS_DONE); 948 label = l10n_util::GetStringUTF16(IDS_DONE);
949 else 949 else
950 label = l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ACCEPT); 950 label = l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ACCEPT);
951 advanced_done_button_->SetText(label); 951 advanced_done_button_->SetText(label);
952 advanced_done_button_->SizeToPreferredSize(); 952 advanced_done_button_->SizeToPreferredSize();
953 if (advanced_view_) 953 if (advanced_view_)
954 advanced_view_->Layout(); 954 advanced_view_->Layout();
955 } 955 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_button.cc ('k') | components/renderer_context_menu/views/toolkit_delegate_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698