Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2790743002: DevTools: fix adding excluded folder from settings screen (Closed)

Created:
3 years, 8 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix adding excluded folder from settings screen This patch makes sure excluded folders in settings screen are initialized regardless of persistence2.0 experiment. BUG=706706, 706714 R=dgozman Review-Url: https://codereview.chromium.org/2790743002 Cr-Commit-Position: refs/heads/master@{#460983} Committed: https://chromium.googlesource.com/chromium/src/+/be9a0b75fbcadccacec188737715ff16c05e7f68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lushnikov
please, take a look
3 years, 8 months ago (2017-03-30 21:07:42 UTC) #1
dgozman
lgtm
3 years, 8 months ago (2017-03-30 21:53:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790743002/1
3 years, 8 months ago (2017-03-31 01:34:02 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:40:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be9a0b75fbcadccacec188737715...

Powered by Google App Engine
This is Rietveld 408576698