Chromium Code Reviews| Index: base/trace_event/memory_dump_request_args.h |
| diff --git a/base/trace_event/memory_dump_request_args.h b/base/trace_event/memory_dump_request_args.h |
| index a8b3f423cad37f4aaaac3b9f395e4f20b509a65a..b01f47e8d7c0fb86f53806c68b28d67df946bd9d 100644 |
| --- a/base/trace_event/memory_dump_request_args.h |
| +++ b/base/trace_event/memory_dump_request_args.h |
| @@ -20,9 +20,7 @@ namespace base { |
| namespace trace_event { |
| // Captures the reason why a memory dump is being requested. This is to allow |
| -// selective enabling of dumps, filtering and post-processing. Important: this |
| -// must be kept consistent with |
| -// services/resource_coordinator/public/cpp/memory/memory_infra_traits.cc. |
|
Primiano Tucci (use gerrit)
2017/03/31 10:47:20
As hjd pointed out, this is just moved to services
fmeawad
2017/03/31 15:07:27
Do you want to replace it or remove it? That file
Primiano Tucci (use gerrit)
2017/03/31 17:04:01
Ah I see we need to update both really. I'd just k
fmeawad
2017/03/31 18:48:40
Done.
|
| +// selective enabling of dumps, filtering and post-processing. |
| enum class MemoryDumpType { |
| PERIODIC_INTERVAL, // Dumping memory at periodic intervals. |
| EXPLICITLY_TRIGGERED, // Non maskable dump request. |
| @@ -31,8 +29,6 @@ enum class MemoryDumpType { |
| }; |
| // Tells the MemoryDumpProvider(s) how much detailed their dumps should be. |
| -// Important: this must be kept consistent with |
| -// services/resource_Coordinator/public/cpp/memory/memory_infra_traits.cc. |
| enum class MemoryDumpLevelOfDetail : uint32_t { |
| FIRST, |
| @@ -55,8 +51,7 @@ enum class MemoryDumpLevelOfDetail : uint32_t { |
| }; |
| // Initial request arguments for a global memory dump. (see |
| -// MemoryDumpManager::RequestGlobalMemoryDump()). Important: this must be kept |
| -// consistent with services/memory_infra/public/cpp/memory_infra_traits.cc. |
| +// MemoryDumpManager::RequestGlobalMemoryDump()). |
| struct BASE_EXPORT MemoryDumpRequestArgs { |
| // Globally unique identifier. In multi-process dumps, all processes issue a |
| // local dump with the same guid. This allows the trace importers to |