[Memory Infra] Update the location of the file where the types are redefined

base/trace_event/memory_dump_request_args.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_REQUEST_ARGS_H_
 #define BASE_TRACE_EVENT_MEMORY_DUMP_REQUEST_ARGS_H_
 
 // This file defines the types and structs used to issue memory dump requests.
 // These are also used in the IPCs for coordinating inter-process memory dumps.
 
 #include <stdint.h>
 #include <map>
 #include <string>
 
 #include "base/base_export.h"
 #include "base/callback.h"
 #include "base/process/process_handle.h"
 
 namespace base {
 namespace trace_event {
 
 // Captures the reason why a memory dump is being requested. This is to allow
-// selective enabling of dumps, filtering and post-processing. Important: this
-// must be kept consistent with
-// services/resource_coordinator/public/cpp/memory/memory_infra_traits.cc.

[Primiano Tucci (use gerrit), 2017/03/31 10:47:20]

As hjd pointed out, this is just moved to
services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

[fmeawad, 2017/03/31 15:07:27]

Do you want to replace it or remove it? That file does not include definitions,
it includes the mapping.
The definition is in
services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom
I can change it to the mojo file, delete it (I think there is enough compile
time checks), or update to the correct traits file. Please advice.

[Primiano Tucci (use gerrit), 2017/03/31 17:04:01]

Ah I see we need to update both really. I'd just keep this short and say: Keep
conssitent with memory_instrumentation_struct_traits.{mojo,cc} (without
specifigyin the full path, can be searched)

[fmeawad, 2017/03/31 18:48:40]

Done.

+// selective enabling of dumps, filtering and post-processing.
 enum class MemoryDumpType {
   PERIODIC_INTERVAL,     // Dumping memory at periodic intervals.
   EXPLICITLY_TRIGGERED,  // Non maskable dump request.
   PEAK_MEMORY_USAGE,     // Dumping memory at detected peak total memory usage.
   LAST = PEAK_MEMORY_USAGE  // For IPC macros.
 };
 
 // Tells the MemoryDumpProvider(s) how much detailed their dumps should be.
-// Important: this must be kept consistent with
-// services/resource_Coordinator/public/cpp/memory/memory_infra_traits.cc.
 enum class MemoryDumpLevelOfDetail : uint32_t {
   FIRST,
 
   // For background tracing mode. The dump time is quick, and typically just the
   // totals are expected. Suballocations need not be specified. Dump name must
   // contain only pre-defined strings and string arguments cannot be added.
   BACKGROUND = FIRST,
 
   // For the levels below, MemoryDumpProvider instances must guarantee that the
   // total size reported in the root node is consistent. Only the granularity of
   // the child MemoryAllocatorDump(s) differs with the levels.
 
   // Few entries, typically a fixed number, per dump.
   LIGHT,
 
   // Unrestricted amount of entries per dump.
   DETAILED,
 
   LAST = DETAILED
 };
 
 // Initial request arguments for a global memory dump. (see
-// MemoryDumpManager::RequestGlobalMemoryDump()). Important: this must be kept
-// consistent with services/memory_infra/public/cpp/memory_infra_traits.cc.
+// MemoryDumpManager::RequestGlobalMemoryDump()).
 struct BASE_EXPORT MemoryDumpRequestArgs {
   // Globally unique identifier. In multi-process dumps, all processes issue a
   // local dump with the same guid. This allows the trace importers to
   // reconstruct the global dump.
   uint64_t dump_guid;
 
   MemoryDumpType dump_type;
   MemoryDumpLevelOfDetail level_of_detail;
 };
 
@@ skipping 40 matching lines @@
 BASE_EXPORT const char* MemoryDumpLevelOfDetailToString(
     const MemoryDumpLevelOfDetail& level_of_detail);
 
 BASE_EXPORT MemoryDumpLevelOfDetail
 StringToMemoryDumpLevelOfDetail(const std::string& str);
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_MEMORY_DUMP_REQUEST_ARGS_H_