Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2790683003: Add ios_chrome_reading_list_egtests as a try job. (Closed)

Created:
3 years, 8 months ago by baxley
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, smut
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ios_chrome_reading_list_egtests as a try job. Add ios_chrome_reading_list_egtests to gn_isolate_map.pyl and ios-simulator-eg.json. BUG=706922 Review-Url: https://codereview.chromium.org/2790683003 Cr-Commit-Position: refs/heads/master@{#461125} Committed: https://chromium.googlesource.com/chromium/src/+/491ee98f77779b5efe9618aaa4b01f23e2326d49

Patch Set 1 #

Patch Set 2 : alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M ios/build/bots/chromium.mac/ios-simulator-eg.json View 2 chunks +20 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +5 lines, -0 lines 0 comments Download
M testing/buildbot/manage.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
baxley
3 years, 8 months ago (2017-03-30 22:32:57 UTC) #2
smut
lgtm but you may need an owners review
3 years, 8 months ago (2017-03-30 22:54:26 UTC) #3
baxley
+dpranke for OWNERS
3 years, 8 months ago (2017-03-30 22:57:46 UTC) #5
baxley
3 years, 8 months ago (2017-03-30 23:04:50 UTC) #7
Dirk Pranke
lgtm
3 years, 8 months ago (2017-03-30 23:45:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790683003/20001
3 years, 8 months ago (2017-03-31 00:33:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/184104)
3 years, 8 months ago (2017-03-31 01:46:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790683003/20001
3 years, 8 months ago (2017-03-31 02:03:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/184221)
3 years, 8 months ago (2017-03-31 03:04:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790683003/20001
3 years, 8 months ago (2017-03-31 03:42:47 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/184272)
3 years, 8 months ago (2017-03-31 04:58:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790683003/20001
3 years, 8 months ago (2017-03-31 14:17:44 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 15:19:01 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/491ee98f77779b5efe9618aaa4b0...

Powered by Google App Engine
This is Rietveld 408576698