[Mac] Set the ptype and pid Crashpad annotations for AlertNotificationService.xpc.

[Mac] Set the ptype and pid Crashpad annotations for AlertNotificationService.xpc.

BUG=699607
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2790683002
Cr-Commit-Position: refs/heads/master@{#460832}
Committed: https://chromium.googlesource.com/chromium/src/+/12b32f2bc2508a15b8e894c9aedc7286e5c0365e

[Robert Sesek, 2017-03-30 17:54:24]

The CQ bit was checked by rsesek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 17:55:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-03-30 18:00:50]

LGTM otherwise

https://codereview.chromium.org/2790683002/diff/1/chrome/browser/ui/cocoa/not...
File chrome/browser/ui/cocoa/notifications/alert_notification_service.mm
(right):

https://codereview.chromium.org/2790683002/diff/1/chrome/browser/ui/cocoa/not...
chrome/browser/ui/cocoa/notifications/alert_notification_service.mm:69:
crashpad::CrashpadInfo::GetCrashpadInfo()->set_simple_annotations(
This should move into the @synchronized block.

Otherwise, T2 comes along while T1’s already in the block, T1 leaves the scope,
CONTEXT SWITCH, T2 enters it and hits the early return on line 61, and leaves
here assuming that crash reporting is set up but without any annotations in
effect.

[Robert Sesek, 2017-03-30 18:04:22]

https://codereview.chromium.org/2790683002/diff/1/chrome/browser/ui/cocoa/not...
File chrome/browser/ui/cocoa/notifications/alert_notification_service.mm
(right):

https://codereview.chromium.org/2790683002/diff/1/chrome/browser/ui/cocoa/not...
chrome/browser/ui/cocoa/notifications/alert_notification_service.mm:69:
crashpad::CrashpadInfo::GetCrashpadInfo()->set_simple_annotations(
On 2017/03/30 18:00:50, Mark Mentovai wrote:
> This should move into the @synchronized block.
> 
> Otherwise, T2 comes along while T1’s already in the block, T1 leaves the
scope,
> CONTEXT SWITCH, T2 enters it and hits the early return on line 61, and leaves
> here assuming that crash reporting is set up but without any annotations in
> effect.

Done.

[Robert Sesek, 2017-03-30 18:04:23]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2017-03-30 18:04:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2790683002/#ps20001
(title: "''")

[commit-bot: I haz the power, 2017-03-30 18:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 18:29:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490897063241760,
"parent_rev": "e6a2ed91fb2df3c4f234ca8824cfb570f902897c", "commit_rev":
"12b32f2bc2508a15b8e894c9aedc7286e5c0365e"}

[commit-bot: I haz the power, 2017-03-30 18:30:16]

Description was changed from

==========
[Mac] Set the ptype and pid Crashpad annotations for
AlertNotificationService.xpc.

BUG=699607
R=mark@chromium.org
==========

to

==========
[Mac] Set the ptype and pid Crashpad annotations for
AlertNotificationService.xpc.

BUG=699607
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2790683002
Cr-Commit-Position: refs/heads/master@{#460832}
Committed:
https://chromium.googlesource.com/chromium/src/+/12b32f2bc2508a15b8e894c9aedc...
==========

[commit-bot: I haz the power, 2017-03-30 18:30:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12b32f2bc2508a15b8e894c9aedc...