chrome/browser/android/webapk/chrome_webapk_host.h - Issue 2790673002: Remove finch flag for play installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/chrome_webapk_host.h

Issue 2790673002: Remove finch flag for play installation. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/webapk/chrome_webapk_host.h

diff --git a/chrome/browser/android/webapk/chrome_webapk_host.h b/chrome/browser/android/webapk/chrome_webapk_host.h

index 153c454b2cc0d8c75a94e26e4d548fd66277ec1c..81de0e7d2b259e159f18b1ca9a59571cccf6e632 100644

--- a/chrome/browser/android/webapk/chrome_webapk_host.h

+++ b/chrome/browser/android/webapk/chrome_webapk_host.h

@@ -17,6 +17,7 @@ enum class GooglePlayInstallState {

SUPPORTED = 0,

DISABLED_OTHER = 1,

NO_PLAY_SERVICES = 2,

+ // DEPRECATED

pkotwicz 2017/03/30 21:55:16 I think that this would be clearer: // Deprecated

Yaron 2017/03/31 13:50:13 Done.

DISABLED_BY_VARIATIONS = 3,

Xi Han 2017/03/30 22:14:11 It's better to update the description in histogram

Yaron 2017/03/31 13:50:13 Done.

DISABLED_BY_PLAY = 4,

MAX = 5