Remove finch flag for play installation.

Remove finch flag for play installation.

The change has rolled out globally - as long as Play is new enough, we should use it.

Review-Url: https://codereview.chromium.org/2790673002
Cr-Commit-Position: refs/heads/master@{#461448}
Committed: https://chromium.googlesource.com/chromium/src/+/f37ff83e96bc94df6f3320c15ae3c3c1a3e302fb

[Yaron, 2017-03-30 17:35:52]

yfriedman@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2017-03-30 21:55:16]

LGTM! I guess that this means that we can now remove the "unsigned sources"
installation flow?

https://codereview.chromium.org/2790673002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/chrome_webapk_host.h (right):

https://codereview.chromium.org/2790673002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/chrome_webapk_host.h:20: // DEPRECATED
I think that this would be clearer:

// Deprecated: DISABLED_BY_VARIATIONS = 3,

and you can remove line 21

[Xi Han, 2017-03-30 22:14:10]

hanxi@chromium.org changed reviewers:
+ hanxi@chromium.org

[Xi Han, 2017-03-30 22:14:11]

https://codereview.chromium.org/2790673002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
(left):

https://codereview.chromium.org/2790673002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:93:
public static boolean isGooglePlayInstallEnabledByChromeFeature() {
You also need to update AppHooksImpl#getGooglePlayWebApkInstallDelegate() in
clank as a separate CL.

https://codereview.chromium.org/2790673002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/chrome_webapk_host.h (right):

https://codereview.chromium.org/2790673002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/chrome_webapk_host.h:21: DISABLED_BY_VARIATIONS =
3,
It's better to update the description in histogram.xml too.

[Yaron, 2017-03-31 13:50:01]

Description was changed from

==========
Remove finch flag for play installation.

The change has rolled out globally - as long as Play is new enough, we should
use it.
==========

to

==========
Remove finch flag for play installation.

The change has rolled out globally - as long as Play is new enough, we should
use it.
==========

[Yaron, 2017-03-31 13:50:01]

yfriedman@chromium.org changed reviewers:
+ mpearson@chromium.org

[Yaron, 2017-03-31 13:50:13]

+mpearson for histogram changes

https://codereview.chromium.org/2790673002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
(left):

https://codereview.chromium.org/2790673002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:93:
public static boolean isGooglePlayInstallEnabledByChromeFeature() {
On 2017/03/30 22:14:11, Xi Han wrote:
> You also need to update AppHooksImpl#getGooglePlayWebApkInstallDelegate() in
> clank as a separate CL.

Already did: https://chrome-internal-review.googlesource.com/#/c/341783/ :)

https://codereview.chromium.org/2790673002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/chrome_webapk_host.h (right):

https://codereview.chromium.org/2790673002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/chrome_webapk_host.h:20: // DEPRECATED
On 2017/03/30 21:55:16, pkotwicz wrote:
> I think that this would be clearer:
> 
> // Deprecated: DISABLED_BY_VARIATIONS = 3,
> 
> and you can remove line 21

Done.

https://codereview.chromium.org/2790673002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/chrome_webapk_host.h:21: DISABLED_BY_VARIATIONS =
3,
On 2017/03/30 22:14:11, Xi Han wrote:
> It's better to update the description in histogram.xml too.

Done.

[Yaron, 2017-03-31 13:51:44]

And ya, I'll get rid of untrusted sources in a separate CL

[Xi Han, 2017-03-31 13:52:19]

LGTM

[Mark P, 2017-03-31 16:32:10]

histograms.xml lgtm

[Yaron, 2017-03-31 16:38:40]

The CQ bit was checked by yfriedman@chromium.org

[Yaron, 2017-03-31 16:38:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2790673002/#ps20001
(title: "Remove finch flag for play installation.")

[commit-bot: I haz the power, 2017-03-31 16:39:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 16:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:57:09]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yaron, 2017-03-31 17:03:07]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:03:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 17:11:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:11:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yaron, 2017-03-31 18:30:33]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:31:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 19:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 19:40:42]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Yaron, 2017-04-03 15:06:57]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2017-04-03 15:07:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 16:22:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491232017669530,
"parent_rev": "a0863c0a8a37eddf7d865636eb8d8ce9962a07bd", "commit_rev":
"f37ff83e96bc94df6f3320c15ae3c3c1a3e302fb"}

[commit-bot: I haz the power, 2017-04-03 16:23:07]

Description was changed from

==========
Remove finch flag for play installation.

The change has rolled out globally - as long as Play is new enough, we should
use it.
==========

to

==========
Remove finch flag for play installation.

The change has rolled out globally - as long as Play is new enough, we should
use it.

Review-Url: https://codereview.chromium.org/2790673002
Cr-Commit-Position: refs/heads/master@{#461448}
Committed:
https://chromium.googlesource.com/chromium/src/+/f37ff83e96bc94df6f3320c15ae3...
==========

[commit-bot: I haz the power, 2017-04-03 16:23:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f37ff83e96bc94df6f3320c15ae3...