Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2790623002: Adding missing include in svg/GradientAttributes.h (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding missing include in svg/GradientAttributes.h If you managed to include GradientAttributes.h before you included SVGGradientElement.h you would have no definition of SVGSpreadMethod and other types. R=fs@opera.com Review-Url: https://codereview.chromium.org/2790623002 Cr-Commit-Position: refs/heads/master@{#460791} Committed: https://chromium.googlesource.com/chromium/src/+/6a9f7d4d9ff9f203411ff11c650ad8b134f43855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/svg/GradientAttributes.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Daniel Bratell
3 years, 8 months ago (2017-03-30 14:16:46 UTC) #1
fs
lgtm
3 years, 8 months ago (2017-03-30 14:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790623002/1
3 years, 8 months ago (2017-03-30 14:56:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790623002/1
3 years, 8 months ago (2017-03-30 14:57:41 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 16:39:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a9f7d4d9ff9f203411ff11c650a...

Powered by Google App Engine
This is Rietveld 408576698